Archived issue #0028213
Visualization, StdPrs_ShadedShape - compute face edges for triangulation-only Faces
Description
The StdPrs_ShadedShape::FillFaceBoundaries() implementation should be extended to handle Faces without Edges defined (triangulation-only).
Steps to reproduce
test bugs vis bug27821 1
Public activity
10 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Dec 12 12:54:25 2016 +0300
0028213: Visualization, StdPrs_ShadedShape - compute face edges for triangulation-only Faces
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Dec 12 12:54:25 2016 +0300
0028213: Visualization, StdPrs_ShadedShape - compute face edges for triangulation-only Faces
Patch is ready for review.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch CR28213 reviewed without remarks, ready for testing.
Dear BugMaster,
Branch CR28213 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1146
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR28213-master-OCCT/Debian70-64/bugs/vis/bug27821.html
http://occt-tests/CR28213-master-OCCT/Windows-64-VC10/bugs/vis/bug27821.html
bugs vis bug27821: OK
Testing on Linux:
occt component :
Total MEMORY difference: 92877240 / 92751958 [+0.14%]
Total CPU difference: 21492.030000000206 / 21420.310000000274 [+0.33%]
products component :
Total MEMORY difference: 30131204 / 30095445 [+0.12%]
Total CPU difference: 5344.3699999999735 / 5303.47999999998 [+0.77%]
Testing on Windows:
occt component :
Total MEMORY difference: 58455723 / 58462136 [-0.01%]
Total CPU difference: 20074.676682998528 / 20176.91973839851 [-0.51%]
products component :
Total MEMORY difference: 20893065 / 20859840 [+0.16%]
Total CPU difference: 5294.081136199971 / 5125.865257899959 [+3.28%]
There are following differences in images found by testdiff.
http://occt-tests/CR28213-master-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR28213-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug27821: bug27821.png differs
Branch CR28213 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1146
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
http://occt-tests/CR28213-master-OCCT/Debian70-64/bugs/vis/bug27821.html
http://occt-tests/CR28213-master-OCCT/Windows-64-VC10/bugs/vis/bug27821.html
bugs vis bug27821: OK
Testing on Linux:
occt component :
Total MEMORY difference: 92877240 / 92751958 [+0.14%]
Total CPU difference: 21492.030000000206 / 21420.310000000274 [+0.33%]
products component :
Total MEMORY difference: 30131204 / 30095445 [+0.12%]
Total CPU difference: 5344.3699999999735 / 5303.47999999998 [+0.77%]
Testing on Windows:
occt component :
Total MEMORY difference: 58455723 / 58462136 [-0.01%]
Total CPU difference: 20074.676682998528 / 20176.91973839851 [-0.51%]
products component :
Total MEMORY difference: 20893065 / 20859840 [+0.16%]
Total CPU difference: 5294.081136199971 / 5125.865257899959 [+3.28%]
There are following differences in images found by testdiff.
http://occt-tests/CR28213-master-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR28213-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs vis bug27821: bug27821.png differs
Dear kgv,
Branch [archived branch] has been rejected due to:
- differences in images
Branch [archived branch] has been rejected due to:
- differences in images
The image difference is expected (checks that patch has effect).
Dear BugMaster,
Branch CR28213 is TESTED.
Branch CR28213 is TESTED.
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]