DiscussionsIssue archiveOCCT:Visualization

Archived issue #0028215

Visualization - define EMPTY type line for consistenct with Interior Style

Open CASCADEOCCT:Visualizationclosed6 public notes

Search issues

Description

There is inconsistency between Fill Area aspects and Line Aspects - while Fill Area aspect defined empty type Aspect_IS_EMPTY (e.g. no faces), there is no such equivalent for Lines.

Such type might be useful in rare cases when specific arrays should be temporarily hidden (while preserving their presentation data).

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Dec 13 12:36:41 2016 +0300

    0028215: Visualization - define EMPTY type line for consistenct with Interior Style
    
    Added new values Aspect_TOL_EMPTY (line type) and Aspect_TOM_EMPTY (marker type).
02Author
Patch is ready for review.
03Commenter 3
Branch CR28215 reviewed without remarks, ready for testing.
04Commenter 4
Dear BugMaster,
Branch CR28215 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1139

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92451401 / 92761416 [-0.33%]
Total CPU difference: 21449.600000000235 / 21420.040000000274 [+0.14%]
products component :
Total MEMORY difference: 30113367 / 30095445 [+0.06%]
Total CPU difference: 5335.949999999976 / 5303.47999999998 [+0.61%]

Testing on Windows:
occt component :
Total MEMORY difference: 58455356 / 58462136 [-0.01%]
Total CPU difference: 20101.430854498583 / 20176.91973839851 [-0.37%]
products component :
Total MEMORY difference: 20893072 / 20859840 [+0.16%]
Total CPU difference: 5299.587971499974 / 5125.865257899959 [+3.39%]

There are no differences in images found by testdiff.
05Commenter 5
Dear BugMaster,
Branch CR28215 is TESTED.
06Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]