Archived issue #0028232
Visualization, StdPrs_ShadedShape - create WireFrame presentation for sole Vertex / Edge / Wire
Description
Current logic contains the following check before creating WF presentation within Shaded presentation builder:
This check prevents displaying presentation for sole TopoDS_Vertex, TopoDS_Edge and TopoDS_Wire shapes - only compounds are allowed.
void wireframeFromShape (const Handle (Prs3d_Presentation)& thePrs,
const TopoDS_Shape& theShape,
const Handle (Prs3d_Drawer)& theDrawer)
{
Standard_Boolean aDrawAllVerticesFlag = (theDrawer->VertexDrawMode() == Prs3d_VDM_All);
if (!aDrawAllVerticesFlag && theShape.ShapeType() != TopAbs_COMPOUND)
{
return;
}
This check prevents displaying presentation for sole TopoDS_Vertex, TopoDS_Edge and TopoDS_Wire shapes - only compounds are allowed.
Public activity
6 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sun Dec 18 10:18:55 2016 +0300
0028232: Visualization, StdPrs_ShadedShape - create WireFrame presentation for sole Vertex / Edge / Wire
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sun Dec 18 10:18:55 2016 +0300
0028232: Visualization, StdPrs_ShadedShape - create WireFrame presentation for sole Vertex / Edge / Wire
Patch is ready for review.
Branch CR28232 reviewed without remarks, ready for testing.
Dear BugMaster,
Branch CR28232 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1138
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 92846098 / 92903246 [-0.06%]
Total CPU difference: 21697.990000000173 / 21640.46000000027 [+0.27%]
products component :
Total MEMORY difference: 30083914 / 30065743 [+0.06%]
Total CPU difference: 5338.439999999985 / 5288.009999999972 [+0.95%]
Testing on Windows:
occt component :
Total MEMORY difference: 58511890 / 58518712 [-0.01%]
Total CPU difference: 20076.51749479842 / 19818.897443398673 [+1.30%]
products component :
Total MEMORY difference: 20894309 / 20861060 [+0.16%]
Total CPU difference: 5267.763767499973 / 5204.302560699983 [+1.22%]
There are no differences in images found by testdiff.
Branch CR28232 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]
Number of compiler warnings:
occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)
products component :
Linux: 63 (63 on master)
Windows: 0 (0 on master)
MacOS : 1138
Regressions/Differences/Improvements:
No regressions/differences
Testing cases:
Not needed
Testing on Linux:
occt component :
Total MEMORY difference: 92846098 / 92903246 [-0.06%]
Total CPU difference: 21697.990000000173 / 21640.46000000027 [+0.27%]
products component :
Total MEMORY difference: 30083914 / 30065743 [+0.06%]
Total CPU difference: 5338.439999999985 / 5288.009999999972 [+0.95%]
Testing on Windows:
occt component :
Total MEMORY difference: 58511890 / 58518712 [-0.01%]
Total CPU difference: 20076.51749479842 / 19818.897443398673 [+1.30%]
products component :
Total MEMORY difference: 20894309 / 20861060 [+0.16%]
Total CPU difference: 5267.763767499973 / 5204.302560699983 [+1.22%]
There are no differences in images found by testdiff.
Dear BugMaster,
Branch CR28232 is TESTED.
Branch CR28232 is TESTED.
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]