Archived issue #0028248
[Regression] HLR Algo result is retrieved from the last added shape only
Description
Found in OCCT 7.1.0 as a regression to 7.0.0.
If multiple shapes are added to HLRBRep_Algo, the extract comound shape (via HLRBRep_HLRToShape) does contain edges from the last added shape only. If the first shape is given as reference shape to the *Compound function, the result is empty. If the shapes are added in reversed order, the result will also change to the then last shape. The hidden line removal itself seems to be correct.
If multiple shapes are added to HLRBRep_Algo, the extract comound shape (via HLRBRep_HLRToShape) does contain edges from the last added shape only. If the first shape is given as reference shape to the *Compound function, the result is empty. If the shapes are added in reversed order, the result will also change to the then last shape. The hidden line removal itself seems to be correct.
Steps to reproduce
pload VISUALIZATION
pload MODELING
box b1 -10 -10 0 20 20 5
pcylinder c1 5 10
hprj proj 0 0 0 0 1 0 0 0 1
houtl b1_outl b1
hfill b1_outl proj 0
hload b1_outl
houtl c1_outl c1
hfill c1_outl proj 0
hload c1_outl
hsetprj proj
hupdate
hhide
hres2d
compound vl v1l vnl vol vil hl h1l hnl hol hil result
vinit
vdisplay result
vaxo
vfit
pload MODELING
box b1 -10 -10 0 20 20 5
pcylinder c1 5 10
hprj proj 0 0 0 0 1 0 0 0 1
houtl b1_outl b1
hfill b1_outl proj 0
hload b1_outl
houtl c1_outl c1
hfill c1_outl proj 0
hload c1_outl
hsetprj proj
hupdate
hhide
hres2d
compound vl v1l vnl vol vil hl h1l hnl hol hil result
vinit
vdisplay result
vaxo
vfit
Public activity
6 archived notes
Participants are labeled by their role within this record.
This error can be fixed with the applied patch. The change is extremely small, so I hope I can contribute this way. The result is still different to 7.0.0 but it looks more correct, and the basic error (result from only the first shape) is resolved.
Please review and integrate into 7.2.1.
Please review and integrate into 7.2.1.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Tue Dec 19 16:01:06 2017 +0300
0028248: [Regression] HLR Algo result is retrieved from the last added shape only
Mistakes in retrieving of HLRBRep_EdgeData by value instead of reference have been corrected.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Tue Dec 19 16:01:06 2017 +0300
0028248: [Regression] HLR Algo result is retrieved from the last added shape only
Mistakes in retrieving of HLRBRep_EdgeData by value instead of reference have been corrected.
Dear Author, thank you for the patch. It will be tested.
Reviewed.
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18448.209999999675 / 18433.219999999703 [+0.08%]
Products
Total CPU difference: 7495.060000000016 / 7463.390000000005 [+0.42%]
Windows-64-VC10:
OCCT
Total CPU difference: 17896.52832059851 / 17919.14846559861 [-0.13%]
Products
Total CPU difference: 7973.273510400013 / 7985.956391699999 [-0.16%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18448.209999999675 / 18433.219999999703 [+0.08%]
Products
Total CPU difference: 7495.060000000016 / 7463.390000000005 [+0.42%]
Windows-64-VC10:
OCCT
Total CPU difference: 17896.52832059851 / 17919.14846559861 [-0.13%]
Products
Total CPU difference: 7973.273510400013 / 7985.956391699999 [-0.16%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]