Archived issue #0028326
Checking invariant shapes in revolve is incomplete
Description
BRepBuilderAPI_Revolve only checks line type curves for invariance. This leads to failed revolve operations, when the revolved body has a linear spline or bezier curve that is coincident with the axis of revolution. Fix is attached.
Steps to reproduce
polyline w 0 0 0 10 0 0 10 5 0 0 0 0
nurbsconvert wn w
revol rn wn 0 0 0 1 0 0 90
An exception was caught [revision removed] : Standard_ConstructionError: Adaptor3d_SurfaceOfRevolution : Axe and meridian are confused
nurbsconvert wn w
revol rn wn 0 0 0 1 0 0 90
An exception was caught [revision removed] : Standard_ConstructionError: Adaptor3d_SurfaceOfRevolution : Axe and meridian are confused
Public activity
11 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Wed Feb 1 12:26:24 2017 +0300
0028326: Checking invariant shapes in revolve is incomplete
Check for bspline and bezier curves coinciding with the axis of rotation.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Wed Feb 1 12:26:24 2017 +0300
0028326: Checking invariant shapes in revolve is incomplete
Check for bspline and bezier curves coinciding with the axis of rotation.
The test for 28003 has been created in the branch. It uses the shape from the bug 28003.
Please test.
Dear Commenter 2,
During building of branch CR28326 ([revision removed]) from occt git-repository (and master from products git-repository) compilation errors have been detected.
On Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28326-master/job/CR28326-master-OCCT-Windows-64-VC10-opt-compile/1/parsed_console/
During building of branch CR28326 ([revision removed]) from occt git-repository (and master from products git-repository) compilation errors have been detected.
On Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28326-master/job/CR28326-master-OCCT-Windows-64-VC10-opt-compile/1/parsed_console/
Dear Mikhail,
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been rejected due to:
- compilation errors
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Wed Feb 1 12:26:24 2017 +0300
0028326: Checking invariant shapes in revolve is incomplete
Check for bspline and bezier curves coinciding with the axis of rotation.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Wed Feb 1 12:26:24 2017 +0300
0028326: Checking invariant shapes in revolve is incomplete
Check for bspline and bezier curves coinciding with the axis of rotation.
Error corrected.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: apv
Date: Tue Feb 7 11:56:13 2017 +0300
Minor correction of test case bugs/modalg_6/bug28003
[revision removed]
Detailed log of new commits:
Author: apv
Date: Tue Feb 7 11:56:13 2017 +0300
Minor correction of test case bugs/modalg_6/bug28003
Dear Commenter 2,
Branch CR28326_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 64
Windows: 0
MacOS: 1200
Regressions/Differences:
Not detected
Testing cases:
bugs modalg_6 bug28326 - OK
http://occt-tests/CR28326_1-master-OCCT/Debian70-64/bugs/modalg_6/bug28326.html
http://occt-tests/CR28326_1-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug28326.html
Testing on Linux:
Total MEMORY difference: 91389383 / 91287887 [+0.11%]
Total CPU difference: 19574.51000000029 / 19662.570000000327 [-0.45%]
Testing on Windows:
Total MEMORY difference: 57126105 / 57124391 [+0.00%]
Total CPU difference: 18358.884084398705 / 18512.045866198645 [-0.83%]
Branch CR28326_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 64
Windows: 0
MacOS: 1200
Regressions/Differences:
Not detected
Testing cases:
bugs modalg_6 bug28326 - OK
http://occt-tests/CR28326_1-master-OCCT/Debian70-64/bugs/modalg_6/bug28326.html
http://occt-tests/CR28326_1-master-OCCT/Windows-64-VC10/bugs/modalg_6/bug28326.html
Testing on Linux:
Total MEMORY difference: 91389383 / 91287887 [+0.11%]
Total CPU difference: 19574.51000000029 / 19662.570000000327 [-0.45%]
Testing on Windows:
Total MEMORY difference: 57126105 / 57124391 [+0.00%]
Total CPU difference: 18358.884084398705 / 18512.045866198645 [-0.83%]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records