DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0028332

Unstable tests in group gdt export

Open CASCADEOCCT:Data Exchangeclosed7 public notes

Search issues

Description

Tests in group gdt export are not stable: some of them fail from time to time.
Here is example of my log, comparing two runs of current master:

STATUS gdt export A3: OK / FAILED
STATUS gdt export B2: FAILED / OK

As far as I can see on both these examples, the problem is that GDT data get lost after writing. Here ix extract from log:

========================== Comparision with reference data ========

Error : 8 differences with reference data found :

 Reference data - NbOfDimensions : 10
 Current data - NbOfDimensions : 10
 Current data after writing - NbOfDimensions : 0

(further the same for other NbOf* parameters)

Steps to reproduce

Not requared.

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Commenter 4.

[revision removed]


Detailed log of new commits:

Author: Commenter 4
Date: Mon Aug 21 15:22:39 2017 +0300

    0028332: Unstable tests in group gdt export
    
    Add initialization of variable GDTMode in STEP writer.
02Commenter 3
@@ -299,6 +299,7 @@ STEPCAFControl_Writer::STEPCAFControl_Writer (const Handle(XSControl_WorkSession
   myLayerMode = Standard_True;
   myPropsMode = Standard_True;
   mySHUOMode = Standard_True;
+  myGDTMode = Standard_True;
 }

It looks dangerous calling any class methods before all class fields have been initialized.
Please move all assignments to members initialization list, and keep only these that should be overridden by Init(), but are there any?
03Commenter 2
Branch [archived branch] has been updated forcibly by Commenter 4.

[revision removed]
04Commenter 4
Dear ABV,

could you please review brach CR28332?

test results:
http://jenkins-test-10.nnov.opencascade.com/view/CR28332-master-ika/
bugs vis bug5682 - unstable test case, which cannot be affected by changes in this issue.
05Commenter 5
No remarks, please integrate
06Commenter 1
Combination -
OCCT branch : [archived branch] : [revision removed]
Products branch : [archived branch]
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.

Number of compiler warnings:

OCCT :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

Products :
Linux: 5 (5 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:

Windows:
OCCT
Total CPU difference: 17330.010689098726 / 17295.75286949859 [+0.20%]
Producst
Total CPU difference: 7688.758886599963 / 7720.302288799964 [-0.41%]

Linux:
OCCT
Total CPU difference: 19451.89000000023 / 19456.560000000376 [-0.02%]
Products
Total CPU difference: 7703.40000000009 / 7725.120000000072 [-0.28%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

07Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]