Archived issue #0028369

Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode

Open CASCADEOCCT:Visualizationclosed9 public notes

Description

In some cases, it is very desirable to control radiance clamping value used by path tracing engine. Smaller value allows to decrease visible noise and get final result (sometimes much) faster, but it introduces extra bias. The main drawback is that caustics may become more dark or even dissapear. The higher value allows to keep path tracing unbiased, but may require more time for image convergence. The default value provides reasonable compromise between these properties, but it is not suitable for all the cases. So, the parameter to control this value is needed.

Steps to reproduce

vrenderparams -maxrad <value>

Public activity

9 archived notes

Participants are labeled by their role within this record.

01Commenter 22017-01-18 14:35

Branch [archived branch] has been created by Author.

[revision removed]

Detailed log of new commits:

Author: Author
Date: Wed Jan 18 14:24:13 2017 +0300

    0028369: Visualization, Path Tracing - Expose radiance clamping setting in path tracing mode

    New parameter was added in the vrenderparams command:
    vrenderparams -maxrad <value>

02Commenter 22017-01-18 14:36

Dear kgv,

Could you please the patch in branch CR28369?

03Commenter 32017-01-18 14:37

New test case was added:
test v3d raytrace sample_cube_clamp

Reference images are attached to this issue.

04Commenter 32017-01-18 16:10

Shader resource files are not re-generated.

05Commenter 22017-01-18 16:56

Branch [archived branch] has been updated forcibly by Author.

[revision removed]

06Commenter 62017-01-18 16:56

Shader resources were regenerated.

07Commenter 32017-01-18 16:58

Please test the patch.

08Commenter 82017-01-19 15:07

Dear BugMaster,

Branch CR28369 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1144

Regressions/Differences:
Not detected

Testing cases:
v3d raytrace sample_cube_clamp - OK
http://occt-tests/CR28369-master-OCCT/Debian70-64/v3d/raytrace/sample_cube_clamp.html
http://occt-tests/CR28369-master-OCCT/Windows-64-VC10/v3d/raytrace/sample_cube_clamp.html

Testing on Linux:
Total MEMORY difference: 93510686 / 92923112 [+0.63%]
Total CPU difference: 21396.580000000173 / 21506.1200000003 [-0.51%]

Testing on Windows:
Total MEMORY difference: 58632152 / 58649007 [-0.03%]
Total CPU difference: 19512.745480898564 / 19749.742200098677 [-1.20%]

09Commenter 22017-02-08 11:36

Branch [archived branch] has been deleted by Commenter 3.

[revision removed]