Archived issue #0028488
VIS - fix compilation with VTK 8.2
Description
The VIS is a nice feature briding two awesome libraries. However, in the current OCCT release VIS depends on VTK 6.1 which is rather old by now. Especially rendering and performance has improved with ongoing VTK releases. So, an update to a recent VTK Version (at least 7.1 - 7.0 has some bugs...) would be awesome.
As a sidenote, IVtkTools_ShapeObject inherits from vtkDataObject but uses the vtkTypeMacro with vtkObject, this is incorrect.
Either use:
class IVtkTools_EXPORT IVtkTools_ShapeObject : public vtkDataObject
vtkTypeMacro (IVtkTools_ShapeObject, vtkDataObject)
or:
class IVtkTools_EXPORT IVtkTools_ShapeObject : public vtkObject
vtkBaseTypeMacro (IVtkTools_ShapeObject, vtkObject)
As a sidenote, IVtkTools_ShapeObject inherits from vtkDataObject but uses the vtkTypeMacro with vtkObject, this is incorrect.
Either use:
class IVtkTools_EXPORT IVtkTools_ShapeObject : public vtkDataObject
vtkTypeMacro (IVtkTools_ShapeObject, vtkDataObject)
or:
class IVtkTools_EXPORT IVtkTools_ShapeObject : public vtkObject
vtkBaseTypeMacro (IVtkTools_ShapeObject, vtkObject)
Additional information
When updating to VTK 7.1 keep in mind that the method "InsertNextTupleValue" will be deprectated. Use "InsertNextTypedTuple" instead. (IVtkVTK_ShapeData).
Public activity
7 archived notes
Participants are labeled by their role within this record.
Hello jengsw,
Once you are interested in VTK 7.1 compatibility, can you prepare the OCCT patch?
Contributing to an open-source product is always appreciated.
Once you are interested in VTK 7.1 compatibility, can you prepare the OCCT patch?
Contributing to an open-source product is always appreciated.
Please find attached the patch with my modifcations to use VTK-7.1 with OCCT-7.1.
This works only for the VTK OpenGL1 Rendering Backend - see 0028208 for the issue with the OpenGL2 Redering backend.
This works only for the VTK OpenGL1 Rendering Backend - see 0028208 for the issue with the OpenGL2 Redering backend.
Branch [archived branch] has been created by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Fri Feb 15 11:27:15 2019 +0300
0028488: VIS - fix compilation with VTK 8.2
Occurrences of removed method vtkDataArray::InsertNextTupleValue() have been replaced by InsertNextTypedTuple().
Fixed misprint in vtkTypeMacro usage for class IVtkTools_ShapeObject.
Patch #0030452 (SelectMgr_ViewerSelector::Deactivate() raises exception when called twice) has been propagated to IVtkOCC_ViewerSelector.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Fri Feb 15 11:27:15 2019 +0300
0028488: VIS - fix compilation with VTK 8.2
Occurrences of removed method vtkDataArray::InsertNextTupleValue() have been replaced by InsertNextTypedTuple().
Fixed misprint in vtkTypeMacro usage for class IVtkTools_ShapeObject.
Patch #0030452 (SelectMgr_ViewerSelector::Deactivate() raises exception when called twice) has been propagated to IVtkOCC_ViewerSelector.
Branch [archived branch] has been updated forcibly by Commenter 4.
[revision removed]
[revision removed]
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16503.939999999908 / 16545.53999999999 [-0.25%]
Products
Total CPU difference: 9076.380000000025 / 9061.810000000012 [+0.16%]
Windows-64-VC14:
OCCT
Total CPU difference: 17918.59375 / 17918.46875 [+0.00%]
Products
Total CPU difference: 10451.5 / 10465.109375 [-0.13%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16503.939999999908 / 16545.53999999999 [-0.25%]
Products
Total CPU difference: 9076.380000000025 / 9061.810000000012 [+0.16%]
Windows-64-VC14:
OCCT
Total CPU difference: 17918.59375 / 17918.46875 [+0.00%]
Products
Total CPU difference: 10451.5 / 10465.109375 [-0.13%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Commenter 4.
[revision removed]
[revision removed]
Related records