Archived issue #0028550
Foundation Classes - fix empty message passed to thrown exception
Description
gp_Dir throws exceptions in many cases, however message is always empty:
This makes description of unhandled exceptions (e.g. using Standard_Failure::GetMessageString()) non-informative.
Standard_ConstructionError_Raise_if (D <= gp::Resolution(), "");
This makes description of unhandled exceptions (e.g. using Standard_Failure::GetMessageString()) non-informative.
Public activity
10 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Apr 18 18:58:12 2017 +0300
0028550: Foundation Classes - fix empty message passed to thrown exception
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Apr 18 18:58:12 2017 +0300
0028550: Foundation Classes - fix empty message passed to thrown exception
Patch is ready for review.
Please remove exclamation signs at the end of exception messages. Also please replace "IsDone() should be checked before" by "no result" to indicate the reason of exception instead of referring to assumed way of misuse.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Apr 18 18:58:12 2017 +0300
0028550: Foundation Classes - fix empty message passed to thrown exception
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Apr 18 18:58:12 2017 +0300
0028550: Foundation Classes - fix empty message passed to thrown exception
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Remarks have been applied.
No remarks, please test
Dear Commenter 1,
Branch CR28550_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 64
Windows: 0
MacOS: 1198
Regressions/Differences:
Not detected
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 92277963 / 90727282 [+1.71%]
Total CPU difference: 19707.110000000313 / 19728.57000000033 [-0.11%]
Testing on Windows:
Total MEMORY difference: 57802591 / 57804189 [-0.00%]
Total CPU difference: 18331.989511998592 / 18136.473458698543 [+1.08%]
Branch CR28550_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
Number of compiler warnings:
occt component:
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MasOS: 0 (0 on master)
products component:
Linux: 64
Windows: 0
MacOS: 1198
Regressions/Differences:
Not detected
Testing cases:
Not needed
Testing on Linux:
Total MEMORY difference: 92277963 / 90727282 [+1.71%]
Total CPU difference: 19707.110000000313 / 19728.57000000033 [-0.11%]
Testing on Windows:
Total MEMORY difference: 57802591 / 57804189 [-0.00%]
Total CPU difference: 18331.989511998592 / 18136.473458698543 [+1.08%]
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Related records