Invalid result of Fuse operation in the test case bugs moddata_2 bug469

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Mar 15 09:15:46 2017 +0300

    0028556: Invalid result of Fuse operation in the test case bugs moddata_2 bug469
    
    1. Using appropriate intersection tolerance for splitting the degenerated edges in Boolean operations (void BOPAlgo_PaveFiller::FillPaves()).
    
    2. Avoid creation of the wires consisting of degenerated edges only (BOPAlgo_WireSplitter).
    
    3. Test case bugs/moddata_2/bug469 has been corrected to obtain valid result of operation. TODO statements have been removed from the case.

The shapes in the test case are slightly misaligned, and this misalignment leads to creation of invalid faces. To resolve that, additionally to the fixes in BOP algorithm, the use of fuzzy value has been added into the test case.

Dear Mikhail, could you please review the git branch CR28556?

src\BOPAlgo\BOPAlgo_PaveFiller_8.cxx
- 234: paves => pave blocks
- 259: double ;;
- aTolCmp should be computed with resolution of only direction of the degenerated edge.

Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 16 14:40:24 2017 +0300

    Small corrections considering remarks.

Corrected. Please review again.

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: msv
Date: Fri Mar 17 19:55:58 2017 +0300

    // small correction

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Mar 15 09:15:46 2017 +0300

    0028556: Invalid result of Fuse operation in the test case bugs moddata_2 bug469
    
    1. Using appropriate intersection tolerance for splitting the degenerated edges in Boolean operations (void BOPAlgo_PaveFiller::FillPaves()).
    
    2. Avoid creation of the wires consisting of degenerated edges only (BOPAlgo_WireSplitter).
    
    3. Test case bugs/moddata_2/bug469 has been corrected to obtain valid result of operation. TODO statements have been removed from the case.

I have made small correction and put the new branch rebased on current master.
Please test.

Dear Commenter 1,
Branch CR28556_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1198

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR28556_1-master-OCCT/Debian70-64/bugs/moddata_2/bug469.html
http://occt-tests/CR28556_1-master-OCCT/Windows-64-VC10/bugs/moddata_2/bug469.html
bugs moddata_2 bug469: OK

Testing on Linux:
occt component :
Total MEMORY difference: 92897520 / 92532835 [+0.39%]
Total CPU difference: 20102.790000000245 / 20174.39000000011 [-0.35%]
products component :
Total MEMORY difference: 31026661 / 31146794 [-0.39%]
Total CPU difference: 5444.639999999978 / 5412.149999999975 [+0.60%]

Testing on Windows:
occt component :
Total MEMORY difference: 57783680 / 57782265 [+0.00%]
Total CPU difference: 18857.182478598552 / 18782.551600198512 [+0.40%]
products component :
Total MEMORY difference: 22292931 / 22254740 [+0.17%]
Total CPU difference: 5453.701359399969 / 5421.409152399973 [+0.60%]

There are following differences in images found by testdiff.
http://occt-tests/CR28556_1-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
IMAGE bugs moddata_2 bug469: bug469.png differs

Dear Commenter 1,
Branch CR28556_1 is TESTED.

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]