DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0028574

Get rid of the TestTopOpe* packages

Open CASCADEOCCT:Modeling Algorithmsclosed16 public notes

Search issues

Description

In view of the removal of the old Boolean operations (BRepAlgo_BooleanOperation) the packages for testing/debugging the old algorithm (TestTopOpe* packages) should be removed.

Steps to reproduce

Not needed.

Public activity

16 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Mar 20 15:30:00 2017 +0300

    0028574: Get rid of the TestTopOpe* packages
    
    1. The TestTopOpe* packages have been removed.
    
    2. The commands *comapre*, *issubshape* and *projponf* have been moved to BRepTest package.
    
    3. The possibility to change the Extrema options has been added to projection algorithm (GeomAPI_ProjectPointOnSurf).
    
    4. Documentation has been updated.
02Commenter 2
Dear Mikhail, could you please review the git branch CR28574?
03Commenter 3
Remarks:

- misprint 'comapre' in commit message.

dox\user_guides\draw_test_harness\draw_test_harness.md
- numeration of subsections is broken:
@subsection occt_draw_6_10 Constraints
@subsubsection occt_draw_6_9_1 cirtang
@subsubsection occt_draw_6_9_2 lintan
@subsection occt_draw_6_11 Display
@subsubsection occt_draw_6_10_1 dmod, discr, defle
@subsubsection occt_draw_6_10_2 nbiso
@subsubsection occt_draw_6_10_3 clpoles, shpoles
@subsubsection occt_draw_6_10_4 clknots, shknots

src\BRepTest\BRepTest_BasicCommands.cxx
- Split log line 1232 like this:
"issubshape subshape shape\n"
"\t\tCheck if the shape is sub-shape of other shape and get its index in the shape.",
- In the command 'issubshape' it would be worth not to stop on first enter of subshape but show all enters.

src\BRepTest\BRepTest_SurfaceCommands.cxx
- Split log line 735 like this:
"projponf face pnt [extrema flag: -min/-max/-minmax] [extrema algo: -g(grad)/-t(tree)]\n"
"\t\tProject point on the face.",

04Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Mar 20 15:30:00 2017 +0300

    0028574: Get rid of the TestTopOpe* packages
    
    1. The TestTopOpe* packages have been removed.
    
    2. The commands *compare*, *issubshape* and *projponf* have been moved to BRepTest package.
    
    3. The possibility to change the Extrema options has been added to projection algorithm (GeomAPI_ProjectPointOnSurf).
    
    4. Documentation has been updated.
05Commenter 5
Done, please review.
06Commenter 6
Reviewed.
07Commenter 7
Dear emv,
could you please rebase branch CR28574_1 on current master,
there are conflict files.

08Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
09Commenter 9
Done.
10Commenter 10
Dear Commenter 1,
Branch CR28574_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1192

Regressions/Differences/Improvements:
http://occt-tests/CR28574_1-master-Products/Debian70-64/unfolding/analytic/A2.html
http://occt-tests/CR28574_1-master-Products/Windows-64-VC10/unfolding/analytic/A2.html
unfolding analytic A2: FAILED (exception)
http://occt-tests/CR28574_1-master-Products/Debian70-64/unfolding/analytic/A3.html
http://occt-tests/CR28574_1-master-Products/Windows-64-VC10/unfolding/analytic/A3.html
unfolding analytic A3: FAILED (exception)

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 91709358 / 92422378 [-0.77%]
Total CPU difference: 20001.690000000093 / 20023.26000000013 [-0.11%]
products component :
Total MEMORY difference: 30808810 / 31021131 [-0.68%]
Total CPU difference: 5469.679999999984 / 5448.519999999973 [+0.39%]
Testing on Windows:
occt component :
Total MEMORY difference: 57650164 / 57766343 [-0.20%]
Total CPU difference: 18831.83231609854 / 18379.710217898588 [+2.46%]
products component :
Total MEMORY difference: 22289804 / 22281694 [+0.04%]
Total CPU difference: 5452.593752299982 / 5345.280664399969 [+2.01%]

There are no differences in images found by testdiff.
11Commenter 11
Dear emv,
Branch [archived branch] has been rejected due to:
- regressions/differences/improvements
12Commenter 12
Dear Mikhail, the failing test cases have been updated. Please check if they are working now.
13Commenter 13
14Commenter 14
Dear Commenter 1,
Branch CR28574_1 from occt git-repository and branch CR28574 from products git-repository are TESTED.
15Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
16Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records