DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0028641

Data Exchange - Support alpha-channel of color

Open CASCADEOCCT:Data Exchangeclosed12 public notes

Search issues

Description

XCAF data structure should be extended to store colors in RGBA formats

Steps to reproduce

bugs xde bug28641

Public activity

12 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Mar 27 10:18:05 2017 +0300

    0028641: Data Exchange - Support alpha-channel of color
    
    Use Quantity_ColorRGBA instead Quantity_Color in XCAFDoc_Color attribute
    Add methods to color tool for processing RGBA
    Update Color driver
    Update Draw commands
02Author
Dear GKA,

could you please review branch CR28641?
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Commenter 4
Branch CR28641 is ready to be tested
05Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
06Commenter 6
Dear Commenter 1,
Branch CR28641 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1191

Regressions/Differences/Improvements:
http://occt-tests/CR28641-master-Products/Debian70-64/sat/read_parallel_2/D9.html
sat read_parallel_2 D9: FAILED

Testing cases:
http://occt-tests/CR28641-master-OCCT/Debian70-64/bugs/xde/bug28641.html
http://occt-tests/CR28641-master-OCCT/Windows-64-VC10/bugs/xde/bug28641.html
bugs xde bug28641: FAILED

Testing on Linux:
occt component :
Total MEMORY difference: 91479940 / 91293001 [+0.20%]
Total CPU difference: 19885.000000000284 / 19613.25000000024 [+1.39%]
products component :
Total MEMORY difference: 30769770 / 30740952 [+0.09%]
Total CPU difference: 5403.739999999984 / 5352.329999999984 [+0.96%]
Testing on Windows:
occt component :
Total MEMORY difference: 57857875 / 57855806 [+0.00%]
Total CPU difference: 18550.328511598444 / 18063.40259029849 [+2.70%]
products component :
Total MEMORY difference: 22295374 / 22257195 [+0.17%]
Total CPU difference: 5401.612625499983 / 5313.206858799958 [+1.66%]

There are no differences in images found by testdiff.
07Commenter 7
Dear ika,
Branch [archived branch] has been rejected due to:
- failed test-case for issue
- regressions/differences/improvements
08Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
09Author
Dear MKV,

the problem was fixed.
10Commenter 10
Dear Commenter 1,
Branch CR28641 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1194

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
http://occt-tests/CR28641-master-OCCT/Debian70-64/bugs/xde/bug28641.html
http://occt-tests/CR28641-master-OCCT/Windows-64-VC10/bugs/xde/bug28641.html
bugs xde bug28641: OK

Testing on Linux:
occt component :
Total MEMORY difference: 91438470 / 91391087 [+0.05%]
Total CPU difference: 19785.720000000314 / 19613.440000000242 [+0.88%]
products component :
Total MEMORY difference: 30848421 / 30770563 [+0.25%]
Total CPU difference: 5372.599999999975 / 5358.419999999984 [+0.26%]
Testing on Windows:
occt component :
Total MEMORY difference: 57858780 / 57855806 [+0.01%]
Total CPU difference: 18595.600001798437 / 18063.40259029849 [+2.95%]
products component :
Total MEMORY difference: 22295378 / 22257195 [+0.17%]
Total CPU difference: 5405.9806534999825 / 5313.206858799958 [+1.75%]

There are no differences in images found by testdiff.
11Commenter 11
Dear Commenter 1,
Branch CR28641 is TESTED.
12Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]

Related records