Archived issue #0028646

Draw Harness, ViewerTest - rename vsetfilter command with vselfilter

Open CASCADEOCCT:DRAWclosed8 public notes

Search issues

Description

#0028365 introduced new command vsetfilter for testing selection filters.
However the command name sounds misnamed - vselfilter would be more expected since command is related to selection.

Public activity

8 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue May 16 16:37:18 2017 +0300

    0028646: Draw Harness, ViewerTest - rename vsetfilter command with vselfilter
    
    TopAbs::ShapeTypeToString() is now used instead of duplicating TopAbs_ShapeEnum printing code.
    vselmode now accepts shape type string for activating standard AIS_Shape selection modes.
02Author
Please test the patch.
03Commenter 3
Dear BugMaster,

Branch CR28646 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 1 (0 on master)
   Windows: 1 (0 on master)
   MasOS: 1 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1192

New warning has been detected during OCCT component building
on Linux:
http://jenkins-test-05.nnov.opencascade.com/view/CR28646-master/job/CR28646-master-OCCT-Debian70-64-opt-compile/1/warnings19Result/
on Windows:
http://jenkins-test-05.nnov.opencascade.com/view/CR28646-master/job/CR28646-master-OCCT-Windows-64-VC10-opt-compile/2/warnings38Result/
on MacOS:
http://jenkins-test-05.nnov.opencascade.com/view/CR28646-master/job/CR28646-master-OCCT-MacOS-opt-compile/1/warnings8Result/

Regressions/Differences:
http://occt-tests/CR28646-master-OCCT/Debian70-64/summary.html
http://occt-tests/CR28646-master-OCCT/Windows-64-VC10/summary.html
bugs vis bug12121

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 92279461 / 91759353 [+0.57%]
Total CPU difference: 18808.670000000246 / 18651.250000000364 [+0.84%]

Testing on Windows:
Total MEMORY difference: 58422506 / 58423846 [-0.00%]
Total CPU difference: 17466.152761798672 / 17338.185141498663 [+0.74%]
04Commenter 4
Dear Kirill,

Branch [archived branch] has been rejected due to:
- additional warnings
- regressions/differences/improvements
05Commenter 1
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed May 17 17:21:53 2017 +0300

    // fix error in test script and compiler warning

06Author
Please check updated patch (only modified test case can be re-checked).
07Commenter 7
Dear BugMaster,

Branch CR28646 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1183

Regressions/Differences:
Not detected

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 92335574 / 91777456 [+0.61%]
Total CPU difference: 18751.12000000032 / 18651.940000000362 [+0.53%]

Testing on Windows:
Total MEMORY difference: 58421648 / 58423846 [-0.00%]
Total CPU difference: 17444.14102069858 / 17338.185141498663 [+0.61%]
08Commenter 1
Branch [archived branch] has been deleted by Author.

[revision removed]