OCCT3D
DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0028687

Offset for open wire is built with incorrect direction

Open CASCADEOCCT:Modeling Algorithmsclosed10 public notes

Search issues

Description

If the source wire is oriented correctly then the offset direction must be on the left side from the wire direction if offset value is negative and on the right side in case of positive offset value.

However, in some cases, this rule is not satisfied (see Steps To Reproduce).

Steps to reproduce

CASE # 1 (test bugs modalg_6 bug26296_5):

restore [locate_data_file bug26296_linesarc.brep] a
vori a
openoffset res a 1 6. i
# See Attachment 1 (PNG)

    CASE # 2 (bugs modalg_5 bug25334_9):
restore [locate_data_file bug25334_faceProlongationCrash1.brep] a
explode a e
wire ww a_3 a_4
donly ww
vori ww
openoffset res ww 1 10
# See Attachment 2 (PNG)

    CASE # 3 (bugs modalg_5 bug25334_4):
restore [locate_data_file bug25334_faceProlongationCrash1.brep] a
explode a e
wire ww a_3
donly ww
vori ww
openoffset res ww 1 -10
# See Attachment 3 (PNG)

Public activity

10 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Cases ## 1 and 2 are reproduced on the current MASTER. Fix for the issue #0028677 solves this problem particularly. However, CASE # 3 is failed even after #0028677 will be fixed. The possible reason is in hard code in KPartCircle(...) function (see src\BRepFill\BRepFill_OffsetWire.cxx).
02Commenter 1
Current bug interdependent with #0028684
03Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: Commenter 1
Date: Thu Aug 26 14:33:56 2021 +0300

    0028687: Offset for open wire is built with incorrect direction
    
    Added new condition to exclude offsetting non closed part of circle as complete circle
04Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
05Commenter 1
Branch for review:
OCCT - CR28687

Results of testing:
http://jenkins-test-occt.nnov.opencascade.com/view/CR28687-master-Commenter 1/view/COMPARE/
06Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
07Commenter 7
Reviewed.

Branches for integration:
OCCT – CR28687
Products – NOT
08Commenter 8
Reviewing
09Commenter 9
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17495.94000000042 / 17441.55000000031 [+0.31%]
Products
Total CPU difference: 11565.440000000113 / 11534.270000000102 [+0.27%]
Windows-64-VC14:
OCCT
Total CPU difference: 19307.140625 / 19200.421875 [+0.56%]
Products
Total CPU difference: 12917.859375 / 12874.53125 [+0.34%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
10Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records