DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0028694

IGES reader produces too small edge covered by its vertices

Open CASCADEOCCT:Data Exchangeclosed29 public notes

Search issues

Description

This bug has been discovered during fixing #23731 as a regression on "test bugs heal bug26671". Actually the shape got by reading from IGES file contains invalidity that is not reported by the current version of checkshape.
It is needed to analyze this case and understand whether the bug is in the IGES file or in the reader algorithm.

Steps to reproduce

igesbrep [locate_data_file bug26671.igs] r *

# check that all edges have enough length
foreach e [explode r e] {
  if {[lsearch [dump $e] degenerated] == -1 &&
      [validrange $e] == "edge has no valid range"} {
    regexp {Mass : *([0-9\-+.eE]+)} [lprops $e] dummy len
    regexp {Tolerance MAX=([0-9\-+.eE]+)} [tolerance $e] dummy tol
    puts "Error: edge $e (lenth=$len, tolerance=$tol) is too small"
  }
}

Public activity

29 archived notes

Participants are labeled by their role within this record.

01Commenter 1
The same bug is in test case "bugs iges buc60823". The command to read the model:
igesbrep [locate_data_file buc60823.igs] r *
02Commenter 2
More test cases with the same issue:
bugs iges buc60850
bugs iges bug58_1
bugs iges bug131_7
bugs iges bug133_1
bugs iges bug272_1
bugs iges bug272_2
bugs iges bug283
bugs iges bug285
bugs iges bug306
bugs iges bug365_3
bugs iges ger61337
bugs modalg_2 bug22893

03Commenter 3
Problem described in issue is reproduced on current state of OCCT.
04Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: skl
Date: Thu Aug 9 12:26:20 2018 +0300

    0028694: IGES reader produces too small edge covered by its vertices
    
    Method IsUClosed() is changed (check distance to middle point is added).
05Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: skl
Date: Thu Aug 9 18:15:41 2018 +0300

    0028694: IGES reader produces too small edge covered by its vertices
    
    Additional check.
06Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: skl
Date: Thu Aug 9 18:19:40 2018 +0300

    0028694: IGES reader produces too small edge covered by its vertices
    
    Additional check.
07Commenter 2
Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: skl
Date: Fri Aug 10 08:14:04 2018 +0300

    0028694: IGES reader produces too small edge covered by its vertices
    
    Additional check 3.
08Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
09Commenter 9
Branch CR28694 is ready to be reviewed.

Results of tests:
http://jenkins-test-12.nnov.opencascade.com/view/CR28694-master-skl/view/COMPARE/
10Commenter 10
Please update method ShapeAnalysis_Surface::IsUClosed and ShapeAnalysis_Surface::IsVClosed to remove redundant sqrt from values of distances
11Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
12Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
13Commenter 13
Branch CR28694 is ready to be reviewed.

Results of tests:
http://jenkins-test-12.nnov.opencascade.com/view/CR28694-master-skl/view/COMPARE/
14Commenter 14
Please note that it is not desirable to change formatting of files during implementation of the fixes. Changing formatting should be performed as separate fix.

Please put only made modification in the class ShapeAnalysis_Surface without additional changing of formatting.
15Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
16Commenter 16
Branch CR28694 is ready to be reviewed.
17Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
18Commenter 18
Please correct check for closure surfaces in the methods IsUClosed() and IsVCLosed (lines 737-745 ; 951-958).
19Commenter 19
Branch CR28694 is ready to be reviewed.
20Commenter 1
21Commenter 21
New bug 30075 is created for regression "bugs step bug55"
22Commenter 22
It is necessary to update test script bugs step bug55 in according with new behavior.
23Commenter 2
Branch [archived branch] has been updated forcibly by Participant.

[revision removed]
24Commenter 24
Test script bugs step bug55 is updated.
25Commenter 25
Branch CR28694 was reviewed
26Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
27Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
28Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
29Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records