Archived issue #0028694
IGES reader produces too small edge covered by its vertices
Description
This bug has been discovered during fixing #23731 as a regression on "test bugs heal bug26671". Actually the shape got by reading from IGES file contains invalidity that is not reported by the current version of checkshape.
It is needed to analyze this case and understand whether the bug is in the IGES file or in the reader algorithm.
It is needed to analyze this case and understand whether the bug is in the IGES file or in the reader algorithm.
Steps to reproduce
igesbrep [locate_data_file bug26671.igs] r *
# check that all edges have enough length
foreach e [explode r e] {
if {[lsearch [dump $e] degenerated] == -1 &&
[validrange $e] == "edge has no valid range"} {
regexp {Mass : *([0-9\-+.eE]+)} [lprops $e] dummy len
regexp {Tolerance MAX=([0-9\-+.eE]+)} [tolerance $e] dummy tol
puts "Error: edge $e (lenth=$len, tolerance=$tol) is too small"
}
}
# check that all edges have enough length
foreach e [explode r e] {
if {[lsearch [dump $e] degenerated] == -1 &&
[validrange $e] == "edge has no valid range"} {
regexp {Mass : *([0-9\-+.eE]+)} [lprops $e] dummy len
regexp {Tolerance MAX=([0-9\-+.eE]+)} [tolerance $e] dummy tol
puts "Error: edge $e (lenth=$len, tolerance=$tol) is too small"
}
}
Public activity
29 archived notes
Participants are labeled by their role within this record.
The same bug is in test case "bugs iges buc60823". The command to read the model:
igesbrep [locate_data_file buc60823.igs] r *
igesbrep [locate_data_file buc60823.igs] r *
More test cases with the same issue:
bugs iges buc60850
bugs iges bug58_1
bugs iges bug131_7
bugs iges bug133_1
bugs iges bug272_1
bugs iges bug272_2
bugs iges bug283
bugs iges bug285
bugs iges bug306
bugs iges bug365_3
bugs iges ger61337
bugs modalg_2 bug22893
bugs iges buc60850
bugs iges bug58_1
bugs iges bug131_7
bugs iges bug133_1
bugs iges bug272_1
bugs iges bug272_2
bugs iges bug283
bugs iges bug285
bugs iges bug306
bugs iges bug365_3
bugs iges ger61337
bugs modalg_2 bug22893
Problem described in issue is reproduced on current state of OCCT.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: skl
Date: Thu Aug 9 12:26:20 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Method IsUClosed() is changed (check distance to middle point is added).
[revision removed]
Detailed log of new commits:
Author: skl
Date: Thu Aug 9 12:26:20 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Method IsUClosed() is changed (check distance to middle point is added).
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: skl
Date: Thu Aug 9 18:15:41 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Additional check.
[revision removed]
Detailed log of new commits:
Author: skl
Date: Thu Aug 9 18:15:41 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Additional check.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: skl
Date: Thu Aug 9 18:19:40 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Additional check.
[revision removed]
Detailed log of new commits:
Author: skl
Date: Thu Aug 9 18:19:40 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Additional check.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: skl
Date: Fri Aug 10 08:14:04 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Additional check 3.
[revision removed]
Detailed log of new commits:
Author: skl
Date: Fri Aug 10 08:14:04 2018 +0300
0028694: IGES reader produces too small edge covered by its vertices
Additional check 3.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch CR28694 is ready to be reviewed.
Results of tests:
http://jenkins-test-12.nnov.opencascade.com/view/CR28694-master-skl/view/COMPARE/
Results of tests:
http://jenkins-test-12.nnov.opencascade.com/view/CR28694-master-skl/view/COMPARE/
Please update method ShapeAnalysis_Surface::IsUClosed and ShapeAnalysis_Surface::IsVClosed to remove redundant sqrt from values of distances
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch CR28694 is ready to be reviewed.
Results of tests:
http://jenkins-test-12.nnov.opencascade.com/view/CR28694-master-skl/view/COMPARE/
Results of tests:
http://jenkins-test-12.nnov.opencascade.com/view/CR28694-master-skl/view/COMPARE/
Please note that it is not desirable to change formatting of files during implementation of the fixes. Changing formatting should be performed as separate fix.
Please put only made modification in the class ShapeAnalysis_Surface without additional changing of formatting.
Please put only made modification in the class ShapeAnalysis_Surface without additional changing of formatting.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch CR28694 is ready to be reviewed.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Please correct check for closure surfaces in the methods IsUClosed() and IsVCLosed (lines 737-745 ; 951-958).
Branch CR28694 is ready to be reviewed.
Please comment regression on :
bugs step bug55
http://occt-tests/IR-WEEK33-OCCT/Debian80-64/bugs/step/bug55.html
http://occt-tests/IR-WEEK33-OCCT/Windows-64-VC14/bugs/step/bug55.html
Original:
http://occt-tests/CR28694-master-skl-OCCT/Debian80-64/summary.html
http://occt-tests/CR28694-master-skl-OCCT/Windows-64-VC14/summary.html
bugs step bug55
http://occt-tests/IR-WEEK33-OCCT/Debian80-64/bugs/step/bug55.html
http://occt-tests/IR-WEEK33-OCCT/Windows-64-VC14/bugs/step/bug55.html
Original:
http://occt-tests/CR28694-master-skl-OCCT/Debian80-64/summary.html
http://occt-tests/CR28694-master-skl-OCCT/Windows-64-VC14/summary.html
New bug 30075 is created for regression "bugs step bug55"
It is necessary to update test script bugs step bug55 in according with new behavior.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Test script bugs step bug55 is updated.
Branch CR28694 was reviewed
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records