Archived issue #0028796

Coding Rules - fix declaration of Move constructor in NCollection_Array1

Open CASCADEOCCT:Codingclosed5 public notes

Search issues

Description

The Move constructor in NCollection_Array1 is declared with const argument:
  NCollection_Array1 (const NCollection_Array1&& theOther)

producing the following compilation error:
c:\occt\src\NCollection\NCollection_Array1.hxx:201: error: C3490: 'myUpperBound' cannot be modified because it is being accessed through a const object

Steps to reproduce

N/A

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon May 29 12:46:59 2017 +0300

    0028796: Coding Rules - fix declaration of Move constructor in NCollection_Array1
02Author
Please check compilation, regression testing is not needed.
03Commenter 3
Dear Commenter 1,
Branch CR28796 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms on Release mode.
[revision removed]

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 0 (0 on master)

products component :
Linux: 64 (64 on master)
Windows: 0 (0 on master)
MacOS : 1197
04Commenter 4
Dear Commenter 1,
Branch CR28796 is TESTED.
05Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records