Archived issue #0028832

MMgt_TShared can be replaced by Standard_Transient

CommunityOCCT:Codingclosed7 public notes

Search issues

Description

From the source code, there is no difference between MMgt_TShared and Standard_Transient. All MMgt_TShared subclasses can be inheritted from Standard_Transient directly. Merge these two classes will simplify the type system and to avoid confusing for developer.

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Dear Commenter 1,

please close the issue as duplicate of #0025572.
02Commenter 3
Branch [archived branch] has been created by Commenter 2.

[revision removed]


Detailed log of new commits:

Author: Commenter 2
Date: Thu Jul 6 10:38:18 2017 +0300

    0028832: MMgt_TShared can be replaced by Standard_Transient
03Commenter 2
CR28832-CR28832-KGV-Products-Debian70-64-opt-tests-compare-linux - Build # 1 - Successful:
Check console output at http://jenkins-test-10.nnov.opencascade.com:8080/job/CR28832-CR28832-KGV-Products-Debian70-64-opt-tests-compare-linux/1/ to view the results.

CR28832-CR28832-KGV-Products-Windows-64-VC10-opt-tests-compare-windows - Build # 1 - Successful:
Check console output at http://jenkins-test-10.nnov.opencascade.com:8080/job/CR28832-CR28832-KGV-Products-Windows-64-VC10-opt-tests-compare-windows/1/ to view the results.
04Commenter 2
Should be integrated.
05Commenter 5
Dear Commenter 1,

Branch CR28832 from occt git-repository (and CR28832 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
[revision removed]
[revision removed]

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 64
   Windows: 0
   MacOS: 1228

Regressions/Differences:
Not detected

Testing cases:
Not required

Testing on Linux:
occt component:
Total MEMORY difference: 92704053 / 92171552 [+0.58%]
Total CPU difference: 19075.140000000276 / 18926.030000000348 [+0.79%]
products component:
Total MEMORY difference: 37290454 / 37299987 [-0.03%]
Total CPU difference: 6464.710000000096 / 6347.520000000062 [+1.85%]

Testing on Windows:
occt component:
Total MEMORY difference: 58838970 / 58850236 [-0.02%]
Total CPU difference: 17946.91664359861 / 17597.770805498705 [+1.98%]
products component:
Total MEMORY difference: 27790526 / 27837358 [-0.17%]
Total CPU difference: 6727.043921800066 / 6587.376226500077 [+2.12%]
06Commenter 6
Dear Commenter 1,

Please integrate branch CR28832 into the occt git-repository master.
Please integrate branch CR28832 into the products git-repository master.
07Commenter 3
Branch [archived branch] has been deleted by Commenter 2.

[revision removed]

Related records