Archived issue #0029220
Application Framework - replace CDM_MessageDriver interface by Message_Messenger
Description
Application Framework defines own messenger interface CDM_MessageDriver.
It would be better merging/replacing this interface by classes from package Message (e.g. Message_Printer is direct replacement for CDM_MessageDriver, Message_PrinterOStream is direct replacement for CDM_COutMessageDriver).
Moreover, Message provides better interface - e.g. it handles message gravity, while messages passed to CDM_MessageDriver are of undefined type (errors, warnings, trace information - everything is passed as is).
But in general, Message_Messenger is a best candidate for CDM_MessageDriver replacement.
It would be better merging/replacing this interface by classes from package Message (e.g. Message_Printer is direct replacement for CDM_MessageDriver, Message_PrinterOStream is direct replacement for CDM_COutMessageDriver).
Moreover, Message provides better interface - e.g. it handles message gravity, while messages passed to CDM_MessageDriver are of undefined type (errors, warnings, trace information - everything is passed as is).
But in general, Message_Messenger is a best candidate for CDM_MessageDriver replacement.
Steps to reproduce
N/A
Public activity
14 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Fri Dec 8 18:08:22 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Pure improvement of OCAF messaging subsystem. Doesn't impact main functionality.
Author: szy
Date: Thu Dec 7 12:28:03 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Fri Dec 1 10:06:10 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Mon Nov 20 16:29:04 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Tue Nov 14 16:54:26 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Fri Oct 13 14:23:55 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Thu Oct 12 15:43:08 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Tue Oct 3 16:23:37 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Thu Sep 28 18:19:56 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
[revision removed]
Detailed log of new commits:
Author: szy
Date: Fri Dec 8 18:08:22 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Pure improvement of OCAF messaging subsystem. Doesn't impact main functionality.
Author: szy
Date: Thu Dec 7 12:28:03 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Fri Dec 1 10:06:10 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Mon Nov 20 16:29:04 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Tue Nov 14 16:54:26 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Fri Oct 13 14:23:55 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Thu Oct 12 15:43:08 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Tue Oct 3 16:23:37 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
Author: szy
Date: Thu Sep 28 18:19:56 2017 +0300
Merge branch 'master' of git.dev.opencascade.org:occt
To be tested.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Wed Dec 13 15:27:50 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Pure improvement of OCAF messaging subsystem. Doesn't impact main functionality.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Wed Dec 13 15:27:50 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Pure improvement of OCAF messaging subsystem. Doesn't impact main functionality.
Tested - http://jenkins-test-10.nnov.opencascade.com/view/CR29220-CR29381-szy/.
Some tests on 'parasolid' & 'sat' components failed, but it seems these errors are not applicable to made modifications which impact only messaging system.
Some tests on 'parasolid' & 'sat' components failed, but it seems these errors are not applicable to made modifications which impact only messaging system.
Review it, please.
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Mon Dec 18 18:05:06 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Correction mechanism of default messenger to PrinterOStream.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Mon Dec 18 18:05:06 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Correction mechanism of default messenger to PrinterOStream.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Wed Dec 13 15:27:50 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Correction mechanism of default messenger to PrinterOStream.
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Pure improvement of OCAF messaging subsystem. Doesn't impact main functionality.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Wed Dec 13 15:27:50 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Correction mechanism of default messenger to PrinterOStream.
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Pure improvement of OCAF messaging subsystem. Doesn't impact main functionality.
The default printer is set as Message_PrinterOStream.
Modified CAM_Application and TDocStd_Aplication classes (cxx & hxx).
Test seems OK except Products tests\CAM-Geodesic\Isoline\A1 computing isoline length. But this case has no connection with OCAF.
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-OCCT-Windows-64-VC10-opt-tests-compare-windows/2/
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-OCCT-Debian70-64-opt-tests-compare-linux/2/
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-Products-Windows-64-VC10-opt-tests-compare-windows/2/
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-Products-Debian70-64-opt-tests-compare-linux/2/
Could you review it.
Modified CAM_Application and TDocStd_Aplication classes (cxx & hxx).
Test seems OK except Products tests\CAM-Geodesic\Isoline\A1 computing isoline length. But this case has no connection with OCAF.
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-OCCT-Windows-64-VC10-opt-tests-compare-windows/2/
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-OCCT-Debian70-64-opt-tests-compare-linux/2/
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-Products-Windows-64-VC10-opt-tests-compare-windows/2/
- http://jenkins-test-10.nnov.opencascade.com:8080/job/CR29220-CR29381-szy-Products-Debian70-64-opt-tests-compare-linux/2/
Could you review it.
Reviewed.
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18502.92999999967 / 18433.219999999703 [+0.38%]
Products
Total CPU difference: 7459.429999999996 / 7463.440000000005 [-0.05%]
Windows-64-VC10:
OCCT
Total CPU difference: 17919.88167029856 / 17919.14846559861 [+0.00%]
Products
Total CPU difference: 7986.283993799983 / 7985.956391699999 [+0.00%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18502.92999999967 / 18433.219999999703 [+0.38%]
Products
Total CPU difference: 7459.429999999996 / 7463.440000000005 [-0.05%]
Windows-64-VC10:
OCCT
Total CPU difference: 17919.88167029856 / 17919.14846559861 [+0.00%]
Products
Total CPU difference: 7986.283993799983 / 7985.956391699999 [+0.00%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: szy
Date: Thu Dec 21 12:51:03 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Replaces duplicated global variable OCCT_DEBUG by OCCT_DEBUGXML
[revision removed]
Detailed log of new commits:
Author: szy
Date: Thu Dec 21 12:51:03 2017 +0300
0029220: Application Framework - replace CDM_MessageDriver interface by Message_Messenger.
//Replaces duplicated global variable OCCT_DEBUG by OCCT_DEBUGXML
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Author.
[revision removed]
[revision removed]
Related records