Archived issue #0029376

Coding Rules, TColStd_PackedMapOfInteger - declare Iterator as nested class of map collection

Open CASCADEOCCT:Codingclosed5 public notes

Search issues

Description

Currently, iterator of TColStd_PackedMapOfInteger is declared as TColStd_MapIteratorOfPackedMapOfInteger in dedicated header file.

It is inconvenient and inconsistent to NCollection classes, which declare iterator as nested class of iterated collection.

Steps to reproduce

N/A

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Dec 7 20:58:36 2017 +0300

    0029376: Coding Rules, TColStd_PackedMapOfInteger - declare Iterator as nested class of map collection
02Author
03Commenter 3
No remarks, please integrate
04Commenter 1
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested on optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18460.609999999684 / 18469.379999999688 [-0.05%]
Products
Total CPU difference: 7507.219999999984 / 7457.620000000003 [+0.67%]
Windows-64-VC10:
OCCT
Total CPU difference: 17870.46055349864 / 17828.96428749855 [+0.23%]
Products
Total CPU difference: 8010.947751899978 / 8009.6685436999705 [+0.02%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]

Related records