DiscussionsIssue archiveOCCT:Configuration

Archived issue #0029409

Configuration, macOS - "AppKit" is spelled in CMake scripts using wrong case for "K"

CommunityOCCT:Configurationclosed8 public notes

Search issues

Description

The following problem has been reported by external user:

~~~~~
The cmake scripts fail to build on case-senstive macOS file systems because Appkit, should be AppKit. Here is a patch against the V7_2_0 tag that solves the problem:

diff --git a/adm/cmake/occt_csf.cmake b/adm/cmake/occt_csf.cmake
index c62425d..0e2db4e 100644
--- a/adm/cmake/occt_csf.cmake
+++ b/adm/cmake/occt_csf.cmake
@@ -85,7 +85,7 @@ if (WIN32)
     set (CSF_objc "objc")

 
     # frameworks
- find_library (Appkit_LIB NAMES Appkit)
+ find_library (Appkit_LIB NAMES AppKit)
     set (CSF_Appkit ${Appkit_LIB})

 
     find_library (IOKit_LIB NAMES IOKit)

~~~~~

Steps to reproduce

Build OCCT on macOS with case sensitive file system (HDD formatted as "Mac OS Extended (Case-sensitive)")

Public activity

8 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Jan 2 14:03:16 2018 +0300

    0029409: Configuration, macOS - "Appkit" is spelled in CMake scripts using wrong case for "K"
    
    Spelling error is corrected in name of AppKit library in CMake scripts for macOS
02Commenter 2
I have pushed correction, please test if possible
03Commenter 3
The patch is incomplete - the misprint is originating from genproj.tcl, where framework is still misspelled.
04Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
05Commenter 5
Corrected (in the same branch), please review
06Commenter 3
Please test the patch (regression testing is not needed - see abv comment).
07Commenter 1
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings
08Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]