Archived issue #0029448
The method Extrema_FuncExtCS::GetStateNumber mixes up parameter on curve with parameter U on surface
Description
The method Extrema_FuncExtCS::GetStateNumber mixes up parameter on curve with parameter U on surface:
Here myU is the parameter U of the solution on surface, and myPoint1 contains parameters of solutions on curve. The code must be the following:
Standard_Real aU = myPoint1(i).Parameter();
if( (myU - aU) * (myU - aU) <= tol2d )
break;
Here myU is the parameter U of the solution on surface, and myPoint1 contains parameters of solutions on curve. The code must be the following:
Standard_Real aT = myPoint1(i).Parameter();
if( (myt - aT) * (myt - aT) <= tol2d )
break;
Steps to reproduce
N/A
Public activity
5 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Jan 25 12:00:46 2018 +0300
0029448: The method Extrema_FuncExtCS::GetStateNumber mixes up parameter on curve with parameter U on surface
The code has been corrected to eliminate the mess.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Jan 25 12:00:46 2018 +0300
0029448: The method Extrema_FuncExtCS::GetStateNumber mixes up parameter on curve with parameter U on surface
The code has been corrected to eliminate the mess.
Dear Igor, please review the branch.
Tests are done in CR29448-master-msv without regressions/improvements.
Tests are done in CR29448-master-msv without regressions/improvements.
Seems to be valid
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18498.499999999694 / 18449.779999999675 [+0.26%]
Products
Total CPU difference: 7496.530000000015 / 7488.530000000009 [+0.11%]
Windows-64-VC10:
OCCT
Total CPU difference: 18008.037835398693 / 17999.364179798602 [+0.05%]
Products
Total CPU difference: 8025.5650455999685 / 8032.819092099977 [-0.09%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18498.499999999694 / 18449.779999999675 [+0.26%]
Products
Total CPU difference: 7496.530000000015 / 7488.530000000009 [+0.11%]
Windows-64-VC10:
OCCT
Total CPU difference: 18008.037835398693 / 17999.364179798602 [+0.05%]
Products
Total CPU difference: 8025.5650455999685 / 8032.819092099977 [-0.09%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]