DiscussionsIssue archiveOCCT:Visualization

Archived issue #0029491

Visualization, AIS_Shape - filter unsupported Display Modes within ::AcceptDisplayMode()

Open CASCADEOCCT:Visualizationclosed6 public notes

Search issues

Description

AIS_Shape does not implement ::AcceptDisplayMode() which makes this presentation accepting any Display Modes, even unsupported ones.

This issue might lead to various application bugs and unexpected behavior.
Thus, the missing method should be added.

In addition, AIS_ColoredShape::Compute() does not filter unsupported Display Modes and computes Wireframe presentation in such cases.
This is also misbehavior which should be fixed.

Steps to reproduce

N/A

Public activity

6 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Feb 8 09:30:39 2018 +0300

    0029491: Visualization, AIS_Shape - filter unsupported Display Modes within ::AcceptDisplayMode()
    
    AIS_Shape::AcceptDisplayMode() now accepts only modes 0,1 and 2.
    AIS_ColoredShape::Compute() no more computes presentation for unknown display mode.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
04Commenter 4
Branch CR29491 reviewed without remarks, ready for testing.
05Commenter 1
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18287.079999999667 / 18606.899999999736 [-1.72%]
Products
Total CPU difference: 7491.640000000005 / 7496.730000000002 [-0.07%]
Windows-64-VC10:
OCCT
Total CPU difference: 17673.66529199852 / 17649.12633469849 [+0.14%]
Products
Total CPU difference: 8071.63214089993 / 8001.213289499973 [+0.88%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
06Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]

Related records