DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0029611

Modeling Algorithms - Misprint in the formula of Hessian computation in the file GeomLib_CheckCurveOnSurface.cxx

Open CASCADEOCCT:Modeling Algorithmsclosed5 public notes

Search issues

Description

Hessian must be equal to the 2nd derivative (https://en.wikipedia.org/wiki/Hessian_matrix). But currently, the 1st derivative is used.

Steps to reproduce

Test case is not required.

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 22 09:53:48 2018 +0300

    0029611: Misprint in the formula of Hessian computation in the file GeomLib_CheckCurveOnSurface.cxx
    
    The formula of Hessian computation has been corrected
02Commenter 2
Dear Mikhail,

Please review the current state of CR29611 branch.

Test results are here: http://jenkins-test-11.nnov.opencascade.com/view/CR0_CCS-master_NBV/

Please note:

1. http://occt-tests/CR0_CCS-master_NBV-Products/Debian70-64/diff-Debian70-64-image.html. IMAGE sat read_parallel_1 A1 is known unstable (confirmed by INV). It is not a regression.

2. The Branch [archived branch] has been tested instead of CR29611. However, these two branches are equivalent.
03Commenter 3
Reviewed.
04Commenter 1
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18152.39999999993 / 18107.97999999989 [+0.25%]
Products
Total CPU difference: 7434.15 / 7427.109999999995 [+0.09%]
Windows-64-VC10:
OCCT
Total CPU difference: 17695.021828898476 / 17842.61437499857 [-0.83%]
Products
Total CPU difference: 8137.901365699974 / 8148.135031299978 [-0.13%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]