Archived issue #0029631

Samples: build AndroidQt sample together with OCCT on Windows platform

Open CASCADEOCCT:Samplesclosed16 public notes

Search issues

Description

AndroidQt sample should be compiled if:

- BUILD_MODULE_QtSamples flag is switched ON,
- Qt5 is used,
- platform is Windows.

Public activity

16 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 10:36:07 2018 +0300

    0029631: Samples: build AndroidQt sample together with OCCT on Windows platform
    
    - _WIN32 definition provides functionality for sample on Windows
    - CMake procedure is changed to have Qt5_FOUND variable defined before compilation modules. Searching of Qt packages is moved into qt.cmake.
02Commenter 3
-    message (STATUS "Info: AndroidQt sample excluded due to Qt5 or GLES2 usage are disabled")
+    message (STATUS "Info: AndroidQt sample excluded due to Qt5 usage is disabled or not Windows platform")

So it is disabled or not Windows platform?

+#ifdef __ANDROID__
+#include "AndroidQt_Window.h"
+#endif
..
+#ifdef _WIN32
+  #include <WNT_Window.hxx>
+#endif
..
+#ifdef _WIN32
+#include <OSD_Environment.hxx>
+#endif

What for theses ifdefs for including headers which are always available?

+#ifdef __ANDROID__
   myView->SetWindow (aWindow, (Aspect_RenderingContext )anEglContext);
+#else
+  myView->SetImmediateUpdate (Standard_False);
+  myView->SetWindow (aWindow, (Aspect_RenderingContext )aRendCtx);
+#endif

Why ::SetImmediateUpdate() is not set for Android?
03Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 11:11:39 2018 +0300

    # set predefined window size for Windows platform
    
    # correct size of "Open" icon on windows to extend viewer working area. It is possible due to icon size is [96,96]

04Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 11:56:16 2018 +0300

    # code improvement on review

05Author
06Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 12:16:44 2018 +0300

    # add SetImmediateUpdate(Standard_False) to avoid unnecessary redraws.

07Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 12:47:20 2018 +0300

    # code improvement

08Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 10:36:07 2018 +0300

    0029631: Samples: build AndroidQt sample together with OCCT on Windows platform
    
    - _WIN32 definition provides functionality for sample on Windows
    - CMake procedure is changed to have Qt5_FOUND variable defined before compilation modules. Searching of Qt packages is moved into qt.cmake.
09Commenter 3
Please consider additional remarks.
10Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 15:14:34 2018 +0300

    # code improvement on remarks

11Commenter 3
Please test the patch.
12Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 15:25:43 2018 +0300

    # code improvement

13Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Mar 23 10:36:07 2018 +0300

    0029631: Samples: build AndroidQt sample together with OCCT on Windows platform
    
    - _WIN32 definition provides functionality for sample on Windows
    - CMake procedure is changed to have Qt5_FOUND variable defined before compilation modules. Searching of Qt packages is moved into qt.cmake.
14Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]
15Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]
16Commenter 2
Branch [archived branch] has been deleted by Commenter 3.

[revision removed]

Related records