Archived issue #0029639
CMake - rename options for building samples
Description
Currently OCCT CMake script contains two options indicating whether to build samples (the latter added by #0029571):
BUILD_MODULE_MfcSample
BUILD_MODULE_QtSample
These names are confusing, since in OCCT term "module" is used for main libraries and not for samples, which are considered as separate components. Having these options inside list of modules (when you work in CMake-GUI) is inconvenient.
I propose renaming these options to, respectively:
BUILD_SAMPLES_MFC
BUILD_SAMPLES_QT
BUILD_MODULE_MfcSample
BUILD_MODULE_QtSample
These names are confusing, since in OCCT term "module" is used for main libraries and not for samples, which are considered as separate components. Having these options inside list of modules (when you work in CMake-GUI) is inconvenient.
I propose renaming these options to, respectively:
BUILD_SAMPLES_MFC
BUILD_SAMPLES_QT
Public activity
6 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Apr 12 06:24:42 2018 +0300
0029639: CMake - rename options for building samples
- BUILD_SAMPLES_MFC instead of BUILD_MODULE_MfcSample
- BUILD_SAMPLES_QT instead of BUILD_MODULE_QtSample
- sub-folder "mfc" of Samples folder in VStudio for mfc samples
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Thu Apr 12 06:24:42 2018 +0300
0029639: CMake - rename options for building samples
- BUILD_SAMPLES_MFC instead of BUILD_MODULE_MfcSample
- BUILD_SAMPLES_QT instead of BUILD_MODULE_QtSample
- sub-folder "mfc" of Samples folder in VStudio for mfc samples
Could you please review,
Jenkins: http://jenkins-test-11.nnov.opencascade.com/view/CR29639-master-NDS/
Jenkins: http://jenkins-test-11.nnov.opencascade.com/view/CR29639-master-NDS/
MFC samples are rearranged in VStudio projects, to have the following structure:
- Modules
- ApplicationFramework
- ...
- Samples
- mfc
- Animation
- Convert
- ...
- qt
- AndroidQt
- FuncDemo
- ...
- Tools
- ...
- Modules
- ApplicationFramework
- ...
- Samples
- mfc
- Animation
- Convert
- ...
- qt
- AndroidQt
- FuncDemo
- ...
- Tools
- ...
Branch [archived branch] has been updated forcibly by Commenter 3.
[revision removed]
[revision removed]
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18044.08999999982 / 18092.32999999989 [-0.27%]
Products
Total CPU difference: 7470.760000000006 / 7480.610000000005 [-0.13%]
Windows-64-VC10:
OCCT
Total CPU difference: 17749.82498019842 / 17813.754189998494 [-0.36%]
Products
Total CPU difference: 8115.406021499984 / 8149.242638399972 [-0.42%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18044.08999999982 / 18092.32999999989 [-0.27%]
Products
Total CPU difference: 7470.760000000006 / 7480.610000000005 [-0.13%]
Windows-64-VC10:
OCCT
Total CPU difference: 17749.82498019842 / 17813.754189998494 [-0.36%]
Products
Total CPU difference: 8115.406021499984 / 8149.242638399972 [-0.42%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]