Archived issue #0029680
Tests - command checkprops does not work for negative values
Description
Check of mass (volume, area, length) properties performed by DRAW command checkprops always passes without error if specified reference value is negative.
Note: apparently the problem has been discovered and fixed during analysis of visual differences after fix of #28903, initially within patch for #29663
Note: apparently the problem has been discovered and fixed during analysis of visual differences after fix of #28903, initially within patch for #29663
Steps to reproduce
pload MODELING
box b 10 10 10
# the following command gives no error in OCCT 7.2.0
checkprops b -v -10
box b 10 10 10
# the following command gives no error in OCCT 7.2.0
checkprops b -v -10
Public activity
8 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sun Apr 8 18:52:31 2018 +0300
0029680: Tests - command checkprops does not work for negative values
DRAW command checkprops is corrected to handle properly negative reference values.
Test case offset faces_face_i E5 is corrected (improvement due to #28903)
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sun Apr 8 18:52:31 2018 +0300
0029680: Tests - command checkprops does not work for negative values
DRAW command checkprops is corrected to handle properly negative reference values.
Test case offset faces_face_i E5 is corrected (improvement due to #28903)
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Fix pushed to CR29680, please review.
The test results are in Jenkins job CR29680-master-abv. Note that failure of test offset faces_face_i E5 was due to remaining extra TODO statement due to incorrect rebase, this is corrected in the last version of the branch. Image differences in OCCT tests and failures on Products tests are apparently due to other changes in the IR_WEEK12 branch on which CR29680 is based.
The test results are in Jenkins job CR29680-master-abv. Note that failure of test offset faces_face_i E5 was due to remaining extra TODO statement due to incorrect rebase, this is corrected in the last version of the branch. Image differences in OCCT tests and failures on Products tests are apparently due to other changes in the IR_WEEK12 branch on which CR29680 is based.
Reviewed.
Dear Commenter 1,
Please exclude the file "CheckCommands.tcl" from remotes/origin/CR29663_2 branch because its functionality is a duplicate of this fix.
Dear Commenter 1,
Please exclude the file "CheckCommands.tcl" from remotes/origin/CR29663_2 branch because its functionality is a duplicate of this fix.
> Please exclude the file "CheckCommands.tcl" from remotes/origin/CR29663_2 branch because its functionality is a duplicate of this fix.
I am sorry.
It is already done in the branch CR29663_3.
I am sorry.
It is already done in the branch CR29663_3.
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18180.84999999974 / 18135.489999999976 [+0.25%]
Products
Total CPU difference: 7464.190000000011 / 7435.139999999992 [+0.39%]
Windows-64-VC10:
OCCT
Total CPU difference: 17769.964709298587 / 17864.39211459853 [-0.53%]
Products
Total CPU difference: 8154.078669399982 / 8129.77371359997 [+0.30%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18180.84999999974 / 18135.489999999976 [+0.25%]
Products
Total CPU difference: 7464.190000000011 / 7435.139999999992 [+0.39%]
Windows-64-VC10:
OCCT
Total CPU difference: 17769.964709298587 / 17864.39211459853 [-0.53%]
Products
Total CPU difference: 8154.078669399982 / 8129.77371359997 [+0.30%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]