Archived issue #0029716
Some TDF and XCAFDoc labels-related issues
Description
Using the API of TDF and XCAFDoc for copying the documents and relocating the attributes between the different parts I found several issues. Some of them are critical:
1. "Descendants" closure mode is not taken into account by TDF closure tool
2. CopyTool always creates a new label at the target ignoring the relocation table
3. XCAFDoc_GraphNode throws an exception if Child of Father is not found during the unsetting
1. "Descendants" closure mode is not taken into account by TDF closure tool
2. CopyTool always creates a new label at the target ignoring the relocation table
3. XCAFDoc_GraphNode throws an exception if Child of Father is not found during the unsetting
Steps to reproduce
Since the usage code is a part of my application, I can't provide any steps to reproduce. Still, the fixed issues are easily observable from the code.
Public activity
7 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Apr 23 15:47:52 2018 +0200
0029716: Fix the following issues -
1. "Descendants" closure mode is not taken into account by TDF closure tool
2. CopyTool always creates a new label at the target ignoring the relocation table
3. XCAFDoc_GraphNode throws an exception if Child of Father is not found during the unsetting
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Apr 23 15:47:52 2018 +0200
0029716: Fix the following issues -
1. "Descendants" closure mode is not taken into account by TDF closure tool
2. CopyTool always creates a new label at the target ignoring the relocation table
3. XCAFDoc_GraphNode throws an exception if Child of Father is not found during the unsetting
Dear gka. The branch is ready for review. Thank you.
Dear Mikhail
Modifications in the XCAFDoc_GraphNode were reviewed.
Could you please review modifications in the TDF_CopyTool
Modifications in the XCAFDoc_GraphNode were reviewed.
Could you please review modifications in the TDF_CopyTool
For me it is ok. Please, test.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 4498.069999999877 / 4489.799999999858 [+0.18%]
Products
Total CPU difference: 7048.440000000028 / 7035.140000000028 [+0.19%]
Windows-64-VC14:
OCCT
Total CPU difference: 17583.703125 / 17600.625 [-0.10%]
Products
Total CPU difference: 8499.21875 / 8526.203125 [-0.32%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 4498.069999999877 / 4489.799999999858 [+0.18%]
Products
Total CPU difference: 7048.440000000028 / 7035.140000000028 [+0.19%]
Windows-64-VC14:
OCCT
Total CPU difference: 17583.703125 / 17600.625 [-0.10%]
Products
Total CPU difference: 8499.21875 / 8526.203125 [-0.32%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records