DiscussionsIssue archiveOCCT:Inspectors

Archived issue #0029743

Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item

Open CASCADEOCCT:Inspectorsclosed14 public notes

Search issues

Description

After opening attached file in inspector and selection of TNaming_UsedShapes attribute, the tool is crashed.

Steps to reproduce

tests/tools/dfbrowser/A7

Public activity

14 archived notes

Participants are labeled by their role within this record.

01Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


No new revisions were added by this update.
02Commenter 1
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue May 8 14:54:18 2018 +0300

    0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
    
    - TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
    - DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.

03Commenter 1
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue May 8 15:12:45 2018 +0300

    # test case

04Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue May 8 15:19:28 2018 +0300

    0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
    
    - TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
    - DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
05Author
Please, review modifications
06Commenter 6
The line
anOS << "Empty Shape" << endl;
gives nothing. I suggest like this:
TCollection_AsciiString entry =...; // put entry of the label with null shape
anOS << "Empty Shape at label = " << entry.ToCString() <<endl;
07Commenter 1
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue May 8 17:55:09 2018 +0300

    0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
    
    - TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
    - TNaming_NamedShape is corrected to have not NULL TNaming_RefShape even if TopoDS_Shape is NULL(TNaming_Builder::Delete).
    - DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
08Author
Could you please, review modifications once again.
09Author
10Commenter 10
Reviewed.
11Commenter 2
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18246.29000000006 / 18243.73999999987 [+0.01%]
Products
Total CPU difference: 0 / 0
Windows-64-VC10:
OCCT
Total CPU difference: 18071.358641298586 / 18049.78370299853 [+0.12%]
Products
Total CPU difference: 7683.610853599943 / 7697.713343999945 [-0.18%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
12Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
13Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]
14Commenter 1
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records