Archived issue #0029743
Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
Description
After opening attached file in inspector and selection of TNaming_UsedShapes attribute, the tool is crashed.
Steps to reproduce
tests/tools/dfbrowser/A7
Public activity
14 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
No new revisions were added by this update.
[revision removed]
No new revisions were added by this update.
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 14:54:18 2018 +0300
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
- TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
- DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 14:54:18 2018 +0300
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
- TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
- DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 15:12:45 2018 +0300
# test case
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 15:12:45 2018 +0300
# test case
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 15:19:28 2018 +0300
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
- TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
- DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 15:19:28 2018 +0300
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
- TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
- DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
Please, review modifications
The line
anOS << "Empty Shape" << endl;
gives nothing. I suggest like this:
TCollection_AsciiString entry =...; // put entry of the label with null shape
anOS << "Empty Shape at label = " << entry.ToCString() <<endl;
anOS << "Empty Shape" << endl;
gives nothing. I suggest like this:
TCollection_AsciiString entry =...; // put entry of the label with null shape
anOS << "Empty Shape at label = " << entry.ToCString() <<endl;
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 17:55:09 2018 +0300
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
- TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
- TNaming_NamedShape is corrected to have not NULL TNaming_RefShape even if TopoDS_Shape is NULL(TNaming_Builder::Delete).
- DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue May 8 17:55:09 2018 +0300
0029743: Samples - Inspector tool - crash by selecting TNaming_UsedShapes tree item
- TNaming_UsedShapes is corrected to do not call methods of empty TopoDS_Shape
- TNaming_NamedShape is corrected to have not NULL TNaming_RefShape even if TopoDS_Shape is NULL(TNaming_Builder::Delete).
- DFBrowserPane presentation tree item for this is corrected in the same way and obsolete methods of processing SortedReferences are removed.
Could you please, review modifications once again.
Jenkins for Branch CR29743_2 is in:
http://jenkins-test-11.nnov.opencascade.com:8080/view/CR29743_1-master-NDS/
http://jenkins-test-11.nnov.opencascade.com:8080/view/CR29743_1-master-NDS/
Reviewed.
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18246.29000000006 / 18243.73999999987 [+0.01%]
Products
Total CPU difference: 0 / 0
Windows-64-VC10:
OCCT
Total CPU difference: 18071.358641298586 / 18049.78370299853 [+0.12%]
Products
Total CPU difference: 7683.610853599943 / 7697.713343999945 [-0.18%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18246.29000000006 / 18243.73999999987 [+0.01%]
Products
Total CPU difference: 0 / 0
Windows-64-VC10:
OCCT
Total CPU difference: 18071.358641298586 / 18049.78370299853 [+0.12%]
Products
Total CPU difference: 7683.610853599943 / 7697.713343999945 [-0.18%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records