Archived issue #0029746
Modeling Algorithms - declare Boolean operation classes in BRepAlgo package as deprecated
Description
After porting of the BRepProj_Projection to use BRepBuilderAPI_Section algorithm (see #0028599), old class BRepAlgo_Section is not used anymore throughout OCCT (except DRAW). It should be declared deprecated to prevent innocent users from using it without knowledge on existence of the better one.
The other BO classes in this package:
Fuse
Common
Cut
should be also declared as deprecated, as they are also not used in OCCT.
The other BO classes in this package:
Fuse
Common
Cut
should be also declared as deprecated, as they are also not used in OCCT.
Steps to reproduce
N/A
Public activity
13 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
No new revisions were added by this update.
[revision removed]
No new revisions were added by this update.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Please review the branch.
Test results are here http://jenkins-test-11.nnov.opencascade.com:8080/view/CR29746-master-msv/view/COMPARE/
Test results are here http://jenkins-test-11.nnov.opencascade.com:8080/view/CR29746-master-msv/view/COMPARE/
+Standard_DEPRECATED("this class is deprecated, use the same from BRepAlgoAPI")
Why message refers to the package instead of direct class name?
-class BRepAlgo_Section : public BRepAlgo_BooleanOperation
+class
+Standard_DEPRECATED("this class is deprecated, use the same from BRepAlgoAPI")
+BRepAlgo_Section : public BRepAlgo_BooleanOperation
I don't know what looks better, but probably putting "class Standard_DEPRECATED" on one line would be helpful for searching in future...
Fill free to ignore this comment.
> class Standard_DEPRECATED("This class is deprecated - UnitsAPI should be used instead") Quantity_Convert
+Standard_DISABLE_DEPRECATION_WARNINGS
Why is that needed here - are there some warning generated without this?
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Fri May 11 10:14:29 2018 +0300
# considering remarks
[revision removed]
Detailed log of new commits:
Author: msv
Date: Fri May 11 10:14:29 2018 +0300
# considering remarks
Please review again.
The macro to disable warning is put in the places where I observed the warning. I have compiled using Jenkins.
The macro to disable warning is put in the places where I observed the warning. I have compiled using Jenkins.
Branch [archived branch] has been updated by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Fri May 11 15:24:47 2018 +0300
# drop redundant changes
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Fri May 11 15:24:47 2018 +0300
# drop redundant changes
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: msv
Date: Thu May 10 11:50:03 2018 +0300
0029746: Modeling Algoriothms - declare Boolean operation classes in BRepAlgo package as deprecated
[revision removed]
Detailed log of new commits:
Author: msv
Date: Thu May 10 11:50:03 2018 +0300
0029746: Modeling Algoriothms - declare Boolean operation classes in BRepAlgo package as deprecated
Branch [archived branch] has been updated forcibly by Commenter 3.
[revision removed]
[revision removed]
Please take the patch from branch CR29746.
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18385.669999999784 / 18243.73999999987 [+0.78%]
Products
Total CPU difference: 7503.440000000055 / 7505.440000000054 [-0.03%]
Windows-64-VC10:
OCCT
Total CPU difference: 18064.291795998535 / 18049.78370299853 [+0.08%]
Products
Total CPU difference: 7677.38641369996 / 7697.713343999945 [-0.26%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 18385.669999999784 / 18243.73999999987 [+0.78%]
Products
Total CPU difference: 7503.440000000055 / 7505.440000000054 [-0.03%]
Windows-64-VC10:
OCCT
Total CPU difference: 18064.291795998535 / 18049.78370299853 [+0.08%]
Products
Total CPU difference: 7677.38641369996 / 7697.713343999945 [-0.26%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Commenter 3.
[revision removed]
[revision removed]
Related records