Archived issue #0029750
Samples - function arrows are not updated by moving a node in FuncDemo qt sample
Description
FuncDemo compiled with Qt 5.10.1 has not updated links as shown on attached picture.
Steps to reproduce
Natasha, could you review please?
The tests passed well: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR29750_1-master-vro/view/COMPARE/
For Commenter 1:
a sample Qt/FuncDemo in the branch CR29750_1.
The tests passed well: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR29750_1-master-vro/view/COMPARE/
For Commenter 1:
a sample Qt/FuncDemo in the branch CR29750_1.
Public activity
15 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Vlad Romashko
Date: Mon Nov 23 11:41:59 2020 +0300
0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
The visual links between functions are recovers.
The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
[revision removed]
Detailed log of new commits:
Author: Vlad Romashko
Date: Mon Nov 23 11:41:59 2020 +0300
0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
The visual links between functions are recovers.
The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
Branch [archived branch] has been created by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Vlad Romashko
Date: Wed Nov 25 10:42:20 2020 +0300
0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
The visual links between functions are recovers.
The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
Also, because Open CASCADE (and OCAF in particular) is improved for usage in multi-threading mode, usage of mutexes is added in this sample (for access to the sharing TNaming_UsedShapes attribute, for example).
[revision removed]
Detailed log of new commits:
Author: Vlad Romashko
Date: Wed Nov 25 10:42:20 2020 +0300
0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
The visual links between functions are recovers.
The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
Also, because Open CASCADE (and OCAF in particular) is improved for usage in multi-threading mode, usage of mutexes is added in this sample (for access to the sharing TNaming_UsedShapes attribute, for example).
Vlad,
what is the purpose for these new confusing comment blocks?
Could them be replaced by simple description?
+//! [0]
what is the purpose for these new confusing comment blocks?
Could them be replaced by simple description?
Dear Vlad,
could you please correct Kirill's remark.
could you please correct Kirill's remark.
Hello Kirill, hello Natasha! These comments come from Qt's sample. All headers in the sample are kept as in Qt sample and all the code, except several lines dedicated to Function Demo.
I suppose the questionable comment comes from a tutorial in Qt. Should we remove these lines? Indeed, we don't need them, but if we remove them, we will introduce more difference to the Qt's sample.
I have no own opinion... If you think it worth removing the lines, I will do it. Just let me know please.
I suppose the questionable comment comes from a tutorial in Qt. Should we remove these lines? Indeed, we don't need them, but if we remove them, we will introduce more difference to the Qt's sample.
I have no own opinion... If you think it worth removing the lines, I will do it. Just let me know please.
Kirill, please check.
It looks reasonable.
It looks reasonable.
OK.
Dear Vlad,
It's Ok, please cherry pick it on the current master and relaunch tests.
Please give details for Igor which branch is.
[signature removed]Natalia
It's Ok, please cherry pick it on the current master and relaunch tests.
Please give details for Igor which branch is.
[signature removed]Natalia
Vlad, could you please also correct git commit author to match common style using acronyms?
Branch [archived branch] has been created by Commenter 4.
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Thu Dec 17 13:17:46 2020 +0300
0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
The visual links between functions are recovered.
The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
Also, because Open CASCADE (and OCAF in particular) is improved for usage in multi-threading mode, usage of mutexes is added in this sample (for access to the sharing TNaming_UsedShapes attribute, for example).
[revision removed]
Detailed log of new commits:
Author: Commenter 4
Date: Thu Dec 17 13:17:46 2020 +0300
0029750: Samples - function arrows are not updated by moving a node in FuncDemo qt sample
The visual links between functions are recovered.
The demo is synchronized with a corresponding demo from Qt (qt486-vc10-32\examples\graphicsview\elasticnodes). It may be successfully compiled by any further versions of Qt including 5.10.1
Also, because Open CASCADE (and OCAF in particular) is improved for usage in multi-threading mode, usage of mutexes is added in this sample (for access to the sharing TNaming_UsedShapes attribute, for example).
Updated to current master.
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17722.770000000193 / 17710.950000000055 [+0.07%]
Products
Total CPU difference: 12416.490000000109 / 12412.520000000126 [+0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19321.5625 / 19274.6875 [+0.24%]
Products
Total CPU difference: 13844.421875 / 13853.046875 [-0.06%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17722.770000000193 / 17710.950000000055 [+0.07%]
Products
Total CPU difference: 12416.490000000109 / 12412.520000000126 [+0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19321.5625 / 19274.6875 [+0.24%]
Products
Total CPU difference: 13844.421875 / 13853.046875 [-0.06%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]