DiscussionsIssue archiveOCCT:Data Exchange

Archived issue #0029888

[Regression] Data Exchange - XCAFDoc_Editor::Expand() removes names

Open CASCADEOCCT:Data Exchangeclosed7 public notes

Search issues

Description

Some names in the Document are last after performing XCAFDoc_Editor::Expand().
This is a regression after #0029599.

Steps to reproduce

bugs xde bug 29888_1
bugs xde bug 29888_2

pload XDE
XOpen Attachment 3 (XBF) D
set aNameBefore [XCheckProps D 0 0:1:1:3]
XExpand D 0
set aNameAfter  [XCheckProps D 0 0:1:1:3]
if { $aNameBefore != $aNameAfter } { puts "Error: name has been lost" }


Expected output:
  Label 0:1:1:3      "LanternPole_Body"

Actual output:
  Label 0:1:1:3      "FACE"

Public activity

7 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Jun 21 17:21:02 2018 +0300

    0029888: [Regression] Data Exchange - XCAFDoc_Editor::Expand() removes names
    
    Add check to prohibit expanding references to assemblies.
02Commenter 3
03Commenter 3
Dear SSV,

could you please review branch CR29888? Test results are in the previous note.
04Commenter 4
Reviewed (no remarks).
05Commenter 1
Shapes were added to data repository
06Commenter 1
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 17095.33999999986 / 17008.500000000095 [+0.51%]
Products
Total CPU difference: 7477.790000000012 / 7460.130000000034 [+0.24%]
Windows-64-VC10:
OCCT
Total CPU difference: 16822.976238898576 / 16834.91031539858 [-0.07%]
Products
Total CPU difference: 8242.827638299887 / 8259.114142699882 [-0.20%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
07Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records