Archived issue #0029939
Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
Description
It is desired to protect BRepGProp_Face::Load() against possible NULL dereference (see #0029926)
Steps to reproduce
pload MODELING VISUALIZATION restore [locate_data bug29926.brep] f vinit View1 vdisplay -dispMode 1 f vfit sprops f vprops f
Public activity
13 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Jul 4 12:09:50 2018 +0300
0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Jul 4 12:09:50 2018 +0300
0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
src/BRepGProp/BRepGProp_Gauss.hxx
- 83, 103: these methods do not return bool.
src/BRepGProp/BRepGProp_Gauss.cxx
- 628: in this place there is still present risk of exception.
The methods of the upper level API (LinearProperties, SurfaceProperties, VolumeProperties of BRepGProp) do not utilize the new return value. So, in the view of this fix, change of API of all methods looks unnecessary.
tests/bugs/modalg_7/bug29939
- there is no need in creation of snapshot for this test.
- 83, 103: these methods do not return bool.
src/BRepGProp/BRepGProp_Gauss.cxx
- 628: in this place there is still present risk of exception.
The methods of the upper level API (LinearProperties, SurfaceProperties, VolumeProperties of BRepGProp) do not utilize the new return value. So, in the view of this fix, change of API of all methods looks unnecessary.
tests/bugs/modalg_7/bug29939
- there is no need in creation of snapshot for this test.
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Jul 10 17:27:29 2018 +0300
# remarks
[revision removed]
Detailed log of new commits:
Author: Author
Date: Tue Jul 10 17:27:29 2018 +0300
# remarks
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Jul 4 12:09:50 2018 +0300
0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
[revision removed]
Detailed log of new commits:
Author: Author
Date: Wed Jul 4 12:09:50 2018 +0300
0029939: Modeling Algorithms - add NULL check to BRepGProp_Face::Load()
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Updated patch is ready for review.
http://jenkins-test-11.nnov.opencascade.com/view/CR29939_1-master-KGV/
http://jenkins-test-11.nnov.opencascade.com/view/CR29939_1-master-KGV/
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Commit message has been completed.
Reviewed.
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 17289.279999999846 / 17169.739999999776 [+0.70%]
Products
Total CPU difference: 7529.330000000048 / 7501.920000000043 [+0.37%]
Windows-64-VC10:
OCCT
Total CPU difference: 16935.46855999858 / 16852.39802749857 [+0.49%]
Products
Total CPU difference: 8237.757605799887 / 8212.11104139987 [+0.31%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian70-64:
OCCT
Total CPU difference: 17289.279999999846 / 17169.739999999776 [+0.70%]
Products
Total CPU difference: 7529.330000000048 / 7501.920000000043 [+0.37%]
Windows-64-VC10:
OCCT
Total CPU difference: 16935.46855999858 / 16852.39802749857 [+0.49%]
Products
Total CPU difference: 8237.757605799887 / 8212.11104139987 [+0.31%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records