Archived issue #0029949

Draw Harness - simplify vtriangle command implementation

Open CASCADEOCCT:DRAWclosed5 public notes

Search issues

Description

Current implementation of vtriangle command creates a presentation using TKMesh algorithm. This looks unnecessary and produces unexpected results (e.g. order of points in drawn triangles does not match order of vtriangle arguments).

Steps to reproduce

N/A

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Jul 11 17:50:39 2018 +0300

    0029949: Draw Harness - simplify vtriangle command implementation
    
    vtriangle and vsegment commands now share presentation created by vdrawparray command.
    
    Added missing accessors to Graphic3d_ArrayOfPrimitives properties
    VertexNumberAllocated(), EdgeNumberAllocated() and BoundNumberAllocated().
02Author
Patch is ready for review.
03Commenter 3
Branch CR29949 reviewed without remarks.
04Commenter 1
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian70-64:
OCCT
Total CPU difference: 17160.600000000017 / 17169.739999999776 [-0.05%]
Products
Total CPU difference: 7462.330000000015 / 7501.920000000043 [-0.53%]
Windows-64-VC10:
OCCT
Total CPU difference: 16892.396683898398 / 16852.39802749857 [+0.24%]
Products
Total CPU difference: 8253.373305899884 / 8212.11104139987 [+0.50%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]