Archived issue #0030100
Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface
Description
ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface. It happens because the UnifySameDomain algorithm uses IntAna_QuadQuadGeo for comparing elementary surfaces (expecting the tangency flag), which returns IntAna_NoGeometricSolution.
The problem has been discovered while working on the issue #0030094.
The problem has been discovered while working on the issue #0030094.
Steps to reproduce
restore [locate_data_file bug30100_usd.brep] f
unifysamedom result f
checkshape result
checknbshapes result -wire 1 -face 1
restore [locate_data_file bug30100_faces.brep] f
explode f
bopcurves f_1 f_2
unifysamedom result f
checkshape result
checknbshapes result -wire 1 -face 1
restore [locate_data_file bug30100_faces.brep] f
explode f
bopcurves f_1 f_2
Public activity
8 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Aug 31 10:07:05 2018 +0300
0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface
When performing intersection of toroidal faces check first if they are based on the same surface.
Test cases for the issue.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Fri Aug 31 10:07:05 2018 +0300
0030100: Modeling Algorithms - ShapeUpgrade_UnifySameDomain is unable to unify faces based on the same toroidal surface
When performing intersection of toroidal faces check first if they are based on the same surface.
Test cases for the issue.
Dear Mikhail, could you please review the git branch CR30100?
Test results - http://jenkins-test-12.nnov.opencascade.com/view/CR30100-CR30100-emv/view/COMPARE/
Test results - http://jenkins-test-12.nnov.opencascade.com/view/CR30100-CR30100-emv/view/COMPARE/
src/IntPatch/IntPatch_Intersection.cxx
- Use TolTang to compare radii in order to make correspondence with IntAna algorithm.
- Use TolTang to compare radii in order to make correspondence with IntAna algorithm.
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Sep 3 15:29:18 2018 +0300
# Corrections according to remarks.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Mon Sep 3 15:29:18 2018 +0300
# Corrections according to remarks.
Please review again. Test results - http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR30094-master-emv/view/COMPARE/.
Reviewed.
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17570.309999999838 / 17510.19999999974 [+0.34%]
Products
Total CPU difference: 7473.800000000058 / 7448.370000000074 [+0.34%]
Windows-64-VC14:
OCCT
Total CPU difference: 17478.18043889853 / 17490.31731669841 [-0.07%]
Products
Total CPU difference: 8335.32063119999 / 8296.913184999985 [+0.46%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17570.309999999838 / 17510.19999999974 [+0.34%]
Products
Total CPU difference: 7473.800000000058 / 7448.370000000074 [+0.34%]
Windows-64-VC14:
OCCT
Total CPU difference: 17478.18043889853 / 17490.31731669841 [-0.07%]
Products
Total CPU difference: 8335.32063119999 / 8296.913184999985 [+0.46%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records