Archived issue #0030142
Application Framework, TPrsStd_AISPresentation - Hidden Presentations Are Computed During Document Retrieval
Description
Please see https://www.opencascade.com/content/prevent-presentation-update-hidden-labels-during-retrieval.
My impression is that the method AfterResume() of TPrsStd_AISPresentation is wrong. It should not call AISUpdate even if the presentation is not displayed at all.
My impression is that the method AfterResume() of TPrsStd_AISPresentation is wrong. It should not call AISUpdate even if the presentation is not displayed at all.
Steps to reproduce
Create an OCAF document, hide everything by erasing the presentations (but do not remove them), store the document and open it - the presentation drivers will update everything even though it is not displayed.
Public activity
9 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Mon Sep 17 11:11:15 2018 +0200
30142: Hidden Presentations Are Computed During Document Retrieval
Removed call to AISUpdate from TPrsStd_AISPresentation::AfterResume().
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Mon Sep 17 11:11:15 2018 +0200
30142: Hidden Presentations Are Computed During Document Retrieval
Removed call to AISUpdate from TPrsStd_AISPresentation::AfterResume().
I was too quick...
Branch [archived branch] has been updated by Author.
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Mon Sep 17 11:17:58 2018 +0200
30142: Hidden Presentations Are Computed During Document Retrieval
AISUpdate() is only called if the presentation is displayed.
[revision removed]
Detailed log of new commits:
Author: Benjamin Bihler
Date: Mon Sep 17 11:17:58 2018 +0200
30142: Hidden Presentations Are Computed During Document Retrieval
AISUpdate() is only called if the presentation is displayed.
Dear VRO could you check this issue since you have a good vision of the presentations behavior in OCAF.
Branch [archived branch] has been created by Commenter 3.
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Tue Sep 18 16:24:06 2018 +0300
Up-to-date version for current master
[revision removed]
Detailed log of new commits:
Author: Commenter 3
Date: Tue Sep 18 16:24:06 2018 +0300
Up-to-date version for current master
Tested: http://vm-jenkins-test-12.nnov.opencascade.com:8080/view/CR30142-master-vro/view/COMPARE/.
The fix is Ok. Up-to-date version for current master is in CR30142_1 branch, please.
The fix is Ok. Up-to-date version for current master is in CR30142_1 branch, please.
Combination -
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17677.699999999695 / 17379.439999999933 [+1.72%]
Products
Total CPU difference: 7498.140000000048 / 7467.690000000077 [+0.41%]
Windows-64-VC14:
OCCT
Total CPU difference: 17510.363445198505 / 17536.33761169853 [-0.15%]
Products
Total CPU difference: 8397.783431599997 / 8382.276932199968 [+0.18%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] SHA - [revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17677.699999999695 / 17379.439999999933 [+1.72%]
Products
Total CPU difference: 7498.140000000048 / 7467.690000000077 [+0.41%]
Windows-64-VC14:
OCCT
Total CPU difference: 17510.363445198505 / 17536.33761169853 [-0.15%]
Products
Total CPU difference: 8397.783431599997 / 8382.276932199968 [+0.18%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]