DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0030151

Modeling Algorithms - Removal of the API level of old Boolean operations algorithm (BRepAlgo_BooleanOperation)

Open CASCADEOCCT:Modeling Algorithmsclosed16 public notes

Search issues

Description

Since OCCT 7.3.0 release the BRepAlgo API classes for performing old Boolean operations have been marked as deprecated.
This issue is intended to remove these classes from OCCT:
- BRepAlgo_BooleanOperation
- BRepAlgo_Fuse
- BRepAlgo_Cut
- BRepAlgo_Common
- BRepAlgo_Section

Steps to reproduce

Not needed.

Public activity

16 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Sep 21 11:43:16 2018 +0300

    0030151: Modeling Algorithms - Removal of the API level of old Boolean operations algorithm (BRepAlgo_BooleanOperation)
    
    The following classes have been removed as obsolete:
    - BRepAlgo_BooleanOperation
    - BRepAlgo_Fuse
    - BRepAlgo_Cut
    - BRepAlgo_Common
    - BRepAlgo_Section
    
    The corresponding classes from BRepAlgoAPI package should be used instead.
    
    Draw commands:
    - fuse
    - cut
    - common
    - section/psection
    have also been removed as obsolete.
    
    The corresponding commands for modern Boolean operations algorithm (bfuse/bcut/bcommon/bsection) should be used instead.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
05Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
06Commenter 3
Eugeny, could you please put a comment which issues block the patch being integrated?
07Commenter 7
I don't think that it is blocked by any other issue. The old API is marked deprecated for a few versions now - probably it is time to get rid of it?
08Commenter 3
Sure, I think it is about time, if Mikhail has no objections - users have 3 releases to update the code.
09Commenter 9
No objections.
10Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Fri Sep 21 11:43:16 2018 +0300

    0030151: Modeling Algorithms - Removal of the API level of old Boolean operations algorithm (BRepAlgo_BooleanOperation)
    
    The following classes have been removed as obsolete:
    - BRepAlgo_BooleanOperation
    - BRepAlgo_Fuse
    - BRepAlgo_Cut
    - BRepAlgo_Common
    - BRepAlgo_Section
    
    The corresponding classes from BRepAlgoAPI package have to be used instead.
    
    Draw commands:
    - fuse
    - cut
    - common
    - section/psection
    have also been removed as obsolete.
    
    The corresponding commands for modern Boolean operations algorithm (bfuse/bcut/bcommon/bsection) have to be used instead.
    
    Adjustment of the test cases to use the commands for modern algorithm.
11Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
12Commenter 12
Dear Mikhail, could you please review git branch CR30151?

Test results - http://jenkins-test-occt.nnov.opencascade.com/view/CR30151-master-emv/view/COMPARE/
13Commenter 13
For integration:
occt - CR30151_1
products - none
14Commenter 14
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17358.54000000042 / 17496.500000000422 [-0.79%]
Products
Total CPU difference: 11397.800000000112 / 11567.680000000111 [-1.47%]
Windows-64-VC14:
OCCT
Total CPU difference: 19328.109375 / 19307.609375 [+0.11%]
Products
Total CPU difference: 12733.328125 / 12920.953125 [-1.45%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
15Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
16Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records