Archived issue #0030180
Data Exchange - VrmlAPI_Writer is expected to return export state
Description
For some reason, VrmlAPI_Writer::WriteDoc(), ::Write() do not return export state in any way.
If file cannot be opened, writer just does not perform any action.
This doesn't look like a robust API.
If file cannot be opened, writer just does not perform any action.
This doesn't look like a robust API.
Steps to reproduce
Not required
Public activity
15 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
The patch CR30180 is ready to review
+ if (outfile.fail())
+ {
+ return Standard_False;
+ }
Check stream to be opened also (aStream.is_open()).
+ {
+ return Standard_False;
+ }
Check stream to be opened also (aStream.is_open()).
Branch [archived branch] has been updated by Participant.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Tue Sep 17 16:57:02 2019 +0300
#remarks from osa
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Tue Sep 17 16:57:02 2019 +0300
#remarks from osa
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
The patch CR30180 is ready to review
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
Please review the branch CR30180_2
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
[revision removed]
Detailed log of new commits:
Author: mzernova
Date: Mon Sep 16 13:44:02 2019 +0300
0030180: Data Exchange - VrmlAPI_Writer is expected to return export state
The VrmlAPI_Writer::WriteDoc() and VrmlAPI_Writer::Write() methods now return the export state.
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16813.57000000016 / 16822.810000000067 [-0.05%]
Products
Total CPU difference: 10542.720000000027 / 10555.120000000048 [-0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 18271.390625 / 18222.765625 [+0.27%]
Products
Total CPU difference: 12493.84375 / 12438.984375 [+0.44%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16813.57000000016 / 16822.810000000067 [-0.05%]
Products
Total CPU difference: 10542.720000000027 / 10555.120000000048 [-0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 18271.390625 / 18222.765625 [+0.27%]
Products
Total CPU difference: 12493.84375 / 12438.984375 [+0.44%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records