Archived issue #0030292
Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
Description
BRepBndLib::Add() has flag to either use triangulation when possible or to use geometric data.
It looks natural that useTriangulation flag affects using any tessellated data for computing bounding box, including Face triangulation as well as Edge polyline, but apparently the latter is not the case.
It is proposed to update implementation and description of the tool to ignore any tessellated data including polygon3d within Edge.
It looks natural that useTriangulation flag affects using any tessellated data for computing bounding box, including Face triangulation as well as Edge polyline, but apparently the latter is not the case.
It is proposed to update implementation and description of the tool to ignore any tessellated data including polygon3d within Edge.
Steps to reproduce
test lowalgos bnd bug30292
Public activity
14 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Oct 25 10:13:44 2018 +0300
0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Oct 25 10:13:44 2018 +0300
0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
It is needed to implement the same logic for edges without faces as for faces: polygon is used if there are no geometry or the flag useTriangulation is true. Geometry is used if the flag useTriangulation is false or there are no polygon.
It seems the proposed patch fixes this well for the method Add(). It is needed to do the same for the method AddOptimal().
Also, it is needed to update the description of the method Add() in the header file.
It seems the proposed patch fixes this well for the method Add(). It is needed to do the same for the method AddOptimal().
Also, it is needed to update the description of the method Add() in the header file.
The non-regression test cases are also needed.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: ifv
Date: Thu Dec 15 16:48:49 2022 +0300
0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
BRepBndLib.cxx : treatment of useTriangulation is modified according to specified behavior of algorithm
BRepTest_CurveCommands.cxx : creation edge from polygon3d is added in Draw command mkedge.
[revision removed]
Detailed log of new commits:
Author: ifv
Date: Thu Dec 15 16:48:49 2022 +0300
0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
BRepBndLib.cxx : treatment of useTriangulation is modified according to specified behavior of algorithm
BRepTest_CurveCommands.cxx : creation edge from polygon3d is added in Draw command mkedge.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch CR30292_1 is ready for review
Test results
http://jenkins-test-10.nnov.opencascade.com/view/CR30292_1-master-ifv/view/COMPARE/
Test results
http://jenkins-test-10.nnov.opencascade.com/view/CR30292_1-master-ifv/view/COMPARE/
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: Commenter 1
Date: Fri Jan 27 15:47:21 2023 +0300
0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
BRepBndLib.cxx : treatment of useTriangulation is modified according to specified behavior of algorithm
BRepTest_CurveCommands.cxx : creation edge from polygon3d is added in Draw command mkedge.
[revision removed]
Detailed log of new commits:
Author: Commenter 1
Date: Fri Jan 27 15:47:21 2023 +0300
0030292: Modeling Algorithms - BRepBndLib should avoid using Poly_Polygon3D when called with useTriangulation set to false
BRepBndLib.cxx : treatment of useTriangulation is modified according to specified behavior of algorithm
BRepTest_CurveCommands.cxx : creation edge from polygon3d is added in Draw command mkedge.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Please, integrate branch:
OCCT - CR30292_2
OCCT - CR30292_2
Combination -
OCCT branch : [archived branch] -
Products branch : [archived branch] -
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18869.980000000163 / 18416.460000000254 [+2.46%]
Products
Total CPU difference: 12095.80000000011 / 12108.910000000147 [-0.11%]
Windows-64-VC142:
OCCT
Total CPU difference: 20579.4375 / 20947.5625 [-1.76%]
Products
Total CPU difference: 13954.984375 / 14923.015625 [-6.49%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch] -
Products branch : [archived branch] -
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 18869.980000000163 / 18416.460000000254 [+2.46%]
Products
Total CPU difference: 12095.80000000011 / 12108.910000000147 [-0.11%]
Windows-64-VC142:
OCCT
Total CPU difference: 20579.4375 / 20947.5625 [-1.76%]
Products
Total CPU difference: 13954.984375 / 14923.015625 [-6.49%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]