Visualization - Won't display line with dot and dash style on Android

Please provide a detailed log from OCCT (Message::DefaultMessenger() interface, redirected to std::cout by default) where errors/warnings can be generated by TKOpenGl driver.

And please provide exact information about tested device (V3d_View::DiagnosticInformation(), see also vglinfo Draw Harness command).

V3d_View::DiagnosticInformation()

EGLVersion : 1.4 Android META-EGL
EGLVendor : Android
EGLClientAPIs : OpenGL_ES
EGLExtensions : EGL_KHR_get_all_proc_addresses EGL_ANDROID_presentation_time EGL_KHR_swap_buffers_with_damage EGL_ANDROID_get_native_client_buffer EGL_ANDROID_front_buffer_auto_refresh EGL_ANDROID_get_frame_timestamps EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_colorspace EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_fence_sync EGL_KHR_create_context EGL_KHR_config_attribs EGL_KHR_surfaceless_context EGL_EXT_create_context_robustness EGL_ANDROID_image_native_buffer EGL_KHR_wait_sync EGL_ANDROID_recordable EGL_KHR_partial_update EGL_KHR_mutable_render_buffer EGL_EXT_protected_content EGL_IMG_context_priority
GLvendor : ARM
GLdevice : Mali-T830
OpenGL ES 3.2 v1.r20p0-01rel0.[revision removed]
GLSLversion : OpenGL ES GLSL ES 3.20
GLdebug : ON
Max texture size : 8192
Max FBO dump size : 8192x8192
Max combined texture units : 96
Max MSAA samples : 4
Viewport : 2160x1080
GLextensions : GL_EXT_debug_marker GL_ARM_rgba8 GL_ARM_mali_shader_binary GL_OES_depth24 GL_OES_depth_texture GL_OES_depth_texture_cube_map GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_EXT_read_format_bgra GL_OES_compressed_paletted_texture GL_OES_compressed_ETC1_RGB8_texture GL_OES_standard_derivatives GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_EGL_sync GL_OES_texture_npot GL_OES_vertex_half_float GL_OES_required_internalformat GL_OES_vertex_array_object GL_OES_mapbuffer GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_type_2_10_10_10_REV GL_OES_fbo_render_mipmap GL_OES_element_index_uint GL_EXT_shadow_samplers GL_OES_texture_compression_astc GL_KHR_texture_compression_astc_ldr GL_KHR_texture_compression_astc_hdr GL_KHR_texture_compression_astc_sliced_3d GL_KHR_debug GL_EXT_occlusion_query_boolean GL_EXT_disjoint_timer_query GL_EXT_blend_minmax GL_EXT_discard_
ResolutionRatio : 1

No other error/warning message from TKOpenGl driver.
While Style Aspect_TOL_SOLID works well.

      EGLVersion: 1.4 Android META-EGL
      GLvendor: Qualcomm
      GLdevice: Adreno (TM) 308
      GLversion: OpenGL ES 3.0 V@145.0 AU@  (GIT@Iaf618d42e3) [GLSL: OpenGL ES GLSL ES 3.00]
      264: 
      265: uniform int   uPattern;;
      266: uniform float uFactor;;
      267: THE_SHADER_IN vec2 ScreenSpaceCoord;
      268: vec4 getColor(void) { return occColor; }
      269: #define getFinalColor getColor
      270: void main()
      271: {
      272:   float anAngle      = atan (dFdx (ScreenSpaceCoord.x), dFdy (ScreenSpaceCoord.y));
      273:   float aRotatePoint = gl_FragCoord.x * sin (anAngle) + gl_FragCoord.y * cos (anAngle);
      274:   uint  aBit         = uint (floor (aRotatePoint / uFactor + 0.5)) & 15U;
      275:   if ((uint (uPattern) & (1U << aBit)) == 0U) discard;
      276:   vec4 aColor = getFinalColor();
      277:   if (aColor.a <= 0.1) discard;
      278:   occSetFragColor (aColor);
      279: }
00:08 TKOpenGl | Type: Error | ID: 0 | Severity: High | Message:
        Failed to compile shader object. Compilation log:
      Fragment shader compilation failed.
      ERROR: 0:265: ';' : Syntax error:  syntax error
      ERROR: 1 compilation errors.  No code generated.

Such a nonsense from driver!
Interesting if it is a driver bug or GLSL specs indeed do not allow empty ;...

Branch [archived branch] has been created by Commenter 2.

[revision removed]


Detailed log of new commits:

Author: Commenter 2
Date: Thu Feb 21 00:23:19 2019 +0300

    0030384: Visualization, OpenGl_ShaderManager - Won't display line with dot and dash style on Android
    
    Fix misprint leading to double semicolon in GLSL code.

Patch fixes issue on Adreno - please check on your Mali device, if possible.

Tested on Mali-T720 - there was the same error.

Check your Message::DefaultMessenger() configuration within application (you need registering your printer to see messages within application interface or to redirect them into system log through __android_log_write(), since std::cout is difficult to see on Android) - OCCT sends errors there, and it is difficult analyzing problem without this log.

See samples/java/jniviewer/jni/OcctJni_MsgPrinter as example.

Please raise the patch.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30384-master-KGV/

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16525.93000000006 / 16569.010000000086 [-0.26%]
Products
Total CPU difference: 9077.360000000022 / 9069.120000000014 [+0.09%]
Windows-64-VC14:
OCCT
Total CPU difference: 18031.921875 / 17934.9375 [+0.54%]
Products
Total CPU difference: 10474.109375 / 10478.703125 [-0.04%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Branch [archived branch] has been deleted by Commenter 2.

[revision removed]