DiscussionsIssue archiveOCCT:Visualization

Archived issue #0030483

Visualization, Path Tracing - make Tile Size configurable

Open CASCADEOCCT:Visualizationclosed12 public notes

Search issues

Description

#0027607 introduced Adaptive screen space sampling within Path Tracing engine, and new parameter Graphic3d_RenderingParams::NbRayTracingTiles managing the amount of tiles for this rendering mode.

Implementation about this flag is confusing - tiles size 32x32 cannot be modified.

Steps to reproduce

N/A

Public activity

12 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Feb 6 19:21:23 2019 +0300

    0030483: Visualization, Path Tracing - Graphic3d_RenderingParams::NbRayTracingTiles parameter is ignored
    
    OpenGl_TileSampler has been refactored to better describe its logic and solve bugs:
    - Tile size is now recomputed based on desired number of tiles instead of hard-coded number 32.
    - Offset image now defines tile index instead of offset to tile origin.
    - Added 2D array defining the number of times to sample tile for straight-forward debugging.
    
    Graphic3d_RenderingParams has been extended with properties
    RayTracingMinTileSize/RayTracingMaxTileSize for testing various tile configurations.
    
    OpenGl_View::initRaytraceResources() now relies on tile properties of OpenGl_TileSampler
    instead of computing numbers of unknown purpose / unclear logic.
    OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
    
    OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.
    Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
04Author
Patch is ready for review.
05Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
06Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Wed Feb 6 19:21:23 2019 +0300

    0030483: Visualization, Path Tracing - make Tile Size configurable
    
    OpenGl_TileSampler has been refactored to better describe its logic:
    - Offset image now defines tile index instead of offset to tile origin.
    - Added 2D array defining the number of times to sample tile for straight-forward debugging.
    
    Graphic3d_RenderingParams has been extended with property
    RayTracingTileSize for testing various tile configurations.
    Default behavior is the following:
    - Target number of tiles (e.g. upper limit per frame): 256
    - Tile size: 32x32.
    
    OpenGl_View::runPathtrace() has been split into two methods per rendering stage.
    OpenGl_Texture::Init() now returns FALSE immediately on 0 input dimensions.
    
    Added Image_PixMapTypedData template class allowing to work with image data of known pixel format.
07Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
08Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
09Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
10Commenter 10
Review without remarks
11Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]
12Commenter 2
Branch [archived branch] has been deleted by Author.

[revision removed]

Related records