Archived issue #0030547
Foundation Classes - NCollection_DoubleMap lacks Seek() method
Description
Other NCollection map classes provide interface for checking existence and fetching value within single query - via methods Seek() returning a pointer or overloaded methods Find() assigning found value passed as second argument.
NCollection_DoubleMap is inconsistent in this context - there are no similar methods.
NCollection_DoubleMap is inconsistent in this context - there are no similar methods.
Steps to reproduce
N/A
Public activity
8 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sat Mar 9 02:32:11 2019 +0300
0030547: Foundation Classes - NCollection_DoubleMap lacks Seek() method
Added Seek1() and Seek2() methods to NCollection_DoubleMap class.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Sat Mar 9 02:32:11 2019 +0300
0030547: Foundation Classes - NCollection_DoubleMap lacks Seek() method
Added Seek1() and Seek2() methods to NCollection_DoubleMap class.
Patch is ready for review.
The check for IsEmpty() in the beginning of the method Seek1() is redundant since this check is made in the initializer of the "for" cycle variable. Macro Standard_NoSuchObject_Raise_if at the beginning of methods Find1() and Find2() (those returning reference) is also redundant for the same reason.
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Corrected.
No more remarks, please integrate. Test results are in Jenkins job CR30547-master-KGV
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16561.69000000007 / 16562.049999999996 [-0.00%]
Products
Total CPU difference: 9087.790000000026 / 9082.700000000026 [+0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 18044.609375 / 17955.015625 [+0.50%]
Products
Total CPU difference: 10459.65625 / 10469.015625 [-0.09%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16561.69000000007 / 16562.049999999996 [-0.00%]
Products
Total CPU difference: 9087.790000000026 / 9082.700000000026 [+0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 18044.609375 / 17955.015625 [+0.50%]
Products
Total CPU difference: 10459.65625 / 10469.015625 [-0.09%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]