DiscussionsIssue archiveOCCT:Visualization

Archived issue #0030571

Visualization, TKOpenGl - mapped texture is ignored while drawing points

Open CASCADEOCCT:Visualizationclosed13 public notes

Search issues

Description

OpenGl_PrimitiveArray unconditionally disables active textures and supports only point sprites (mapped using generated texture coordinates within the point dimensions).

This disallows mapping features like Color Scale onto point cloud.

Public activity

13 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 14 02:03:50 2019 +0300

    0030571: Visualization, TKOpenGl - mapped texture is ignored while drawing points
    
    OpenGl_AspectsTextureSet now appends Sprite texture to the end of texture set.
    OpenGl_Context::init() - fixed usage of GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS on too old GL context.

Author: Author
Date: Wed Mar 13 21:46:24 2019 +0300

    0030570: Visualization, TKOpenGl - OpenGl_AspectFace ignores texture revision on recompute
    
    Added revision check to one more branch within OpenGl_AspectsTextureSet::build().
02Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 14 16:15:36 2019 +0300

    Default sampler names occSampler0, occActiveSampler and occSamplerBaseColor
    are now excluded from header with common declarations for build-in GLSL programs.
    
    OpenGl_ShaderObject::LoadAndCompile() and OpenGl_ShaderProgram::Link()
    now includes program Id within error log.
    
    OpenGl_ShaderManager now supports mapping texture onto point primitive within built-in programs
    (texture transformation is ignored).

03Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 14 17:33:42 2019 +0300

    # added simple test case

04Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 14 02:03:50 2019 +0300

    0030571: Visualization, TKOpenGl - mapped texture is ignored while drawing points
    
    OpenGl_AspectsTextureSet now appends Sprite texture to the end of texture set.
    OpenGl_Context::init() - fixed usage of GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS on too old GL context.
    
    Default sampler names occSampler0, occActiveSampler and occSamplerBaseColor
    are now excluded from header with common declarations for build-in GLSL programs.
    
    OpenGl_ShaderObject::LoadAndCompile() and OpenGl_ShaderProgram::Link()
    now includes program Id within error log.
    
    OpenGl_ShaderManager now supports mapping texture onto point primitive within built-in programs
    (texture transformation is ignored).
05Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 14 19:14:54 2019 +0300

    # fix environment mapping on trihedron

06Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Mar 14 02:03:50 2019 +0300

    0030571: Visualization, TKOpenGl - mapped texture is ignored while drawing points
    
    OpenGl_AspectsTextureSet now appends Sprite texture to the end of texture set.
    OpenGl_Context::init() - fixed usage of GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS on too old GL context.
    
    Default sampler names occSampler0, occActiveSampler and occSamplerBaseColor
    are now excluded from header with common declarations for build-in GLSL programs.
    
    OpenGl_ShaderObject::LoadAndCompile() and OpenGl_ShaderProgram::Link()
    now includes program Id within error log.
    
    OpenGl_ShaderManager now supports mapping texture onto point primitive within built-in programs
    (texture transformation is ignored).
07Author
Patch is ready for review.
08Commenter 8
The branch CR30571_2 is reviewed without remarks
09Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16595.900000000023 / 16599.24999999996 [-0.02%]
Products
Total CPU difference: 9084.690000000026 / 9092.71000000004 [-0.09%]
Windows-64-VC14:
OCCT
Total CPU difference: 18019.265625 / 17985.28125 [+0.19%]
Products
Total CPU difference: 10459.234375 / 10460.953125 [-0.02%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
10Commenter 2
Branch [archived branch] has been updated by Commenter 1.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sat Mar 16 15:20:25 2019 +0300

    # 0030571 OpenGL ES compilation fix

11Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
12Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
13Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records