DiscussionsIssue archiveOCCT:Modeling Algorithms

Archived issue #0030584

Modeling Algorithms, BRepFill_OffsetWire - access violation on Face having no boundaries

Open CASCADEOCCT:Modeling Algorithmsclosed5 public notes

Search issues

Description

BRepFill_OffsetWire lacks checks on input Face having no boundaries leading to Access violation on working with uninitialized properties.

Steps to reproduce

offset wire_closed_inside_0_005 H6

Public activity

5 archived notes

Participants are labeled by their role within this record.

01Commenter 3
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Sat Mar 16 13:22:47 2019 +0300

    0030584: Modeling Algorithms, BRepFill_OffsetWire - access violation on Face having no boundaries
    
    Added missing NULL and empty result checks.
    Updated test cases using offset_wire_092.brep shape containing all Edges
    with TopAbs_INTERNAL orientation (hense no boundary to make offset).
02Author
03Commenter 3
Reviewed.
04Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16619.430000000022 / 16599.24999999996 [+0.12%]
Products
Total CPU difference: 9089.650000000058 / 9092.71000000004 [-0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 18008.09375 / 17985.28125 [+0.13%]
Products
Total CPU difference: 10477.625 / 10460.953125 [+0.16%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
05Commenter 3
Branch [archived branch] has been deleted by Participant.

[revision removed]

Related records