Foundation Classes, TColStd_PackedMapOfInteger - broken triangulation within 32-bit builds

Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon May 20 11:39:48 2019 +0300

    0030718: Mesh - broken triangulation within 32-bit builds
    
    NCollection maps - throw exception on invalid range returned by HashCode().

Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon May 20 11:40:37 2019 +0300

    TColStd_PackedMapOfInteger - revert HashCode modification.

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: tiv
Date: Mon May 20 17:16:12 2019 +0300

    0030718: Mesh - broken triangulation within 32-bit builds
    
    The problem caused by the changing of HashCode() method of TColStd_PackedMapOfInteger::TColStd_intMapNode class done as a part of 30550 changes is solved.

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Branch [archived branch] has been updated forcibly by Participant.

[revision removed]

Patch is ready for review: http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30718-master-TIV/view/ALL/

 private:
   unsigned int      myMask;
   unsigned int      myData;
+
+  //! Returns the key of this map node with the mask applied to it
+  //! @return the key of this map node with the mask applied to it
+  unsigned int maskedKey() const
+  {
+    return ::maskedKey (myMask);
+  }

Methods should not be mixed with class fields.

+  //! Returns the key of this map node with the mask applied to it
+  //! @return the key of this map node with the mask applied to it
+  unsigned int maskedKey() const

Duplicating description is not helpful.

Reviewed.

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: tiv
Date: Tue May 21 14:55:38 2019 +0300

    # Reviewer's remarks on coding style are taken into account.

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: tiv
Date: Tue May 21 16:18:48 2019 +0300

    0030718: Mesh - broken triangulation within 32-bit builds
    
    The problem caused by the changing of HashCode() method of TColStd_PackedMapOfInteger::TColStd_intMapNode class done as a part of 30550 changes is solved.

Dear Commenter 1,

please, test branch CR30718_1 on some of 32-bit configurations (e.g. on Windows 32-bit).

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16329.710000000065 / 16353.149999999998 [-0.14%]
Products
Total CPU difference: 10523.690000000062 / 10547.03000000006 [-0.22%]
Windows-64-VC14:
OCCT
Total CPU difference: 17750.546875 / 17737.640625 [+0.07%]
Products
Total CPU difference: 12112.921875 / 12094.59375 [+0.15%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]