DiscussionsIssue archiveOCCT:Foundation Classes

Archived issue #0030804

Foundation Classes - Poly_Connect crashes due to out-of-range array modification

Open CASCADEOCCT:Foundation Classesclosed12 public notes

Search issues

Description

Poly_Connect crashes on some triangulations due to out-of-range memory access.

Steps to reproduce

pload MODELING VISUALIZATION
restore Attachment 1 (BREP) b
vclear
vinit View1
vdisplay b
vfit


Result:
Error: AIS_Shape::Compute() wireframe presentation builder has failed (ACCESS VIOLATION at address 0xFFFFFFFFFFFFFFFF during 'READ' operation)

Public activity

12 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Mon Jun 24 13:07:04 2019 +0300

    0030804: Foundation Classes - Poly_Connect crash due to out-of-range array modification
    
    Fixed initialization of edges array based on the wrong statement.
02Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
03Author
04Commenter 4
- src/Poly/Poly_Connect.cxx
line 129-130, 166, 181-182 - The comments are not relevant with new variables

The attached shape has not been put into data base before testing, so obviously the test case has failed.
I've put the shape into data base now. Please restart the failing test cases.
05Author
06Commenter 2
Branch [archived branch] has been updated by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Tue Jun 25 11:29:25 2019 +0300

    # updated comments

07Commenter 7
line 166 - please change "fore each edge in triangle" to "for each edge in triangle"
08Commenter 2
Branch [archived branch] has been updated forcibly by Author.

[revision removed]
09Author
Misprint fixed.
10Commenter 10
Reviewed.
11Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16475.69 / 16513.620000000094 [-0.23%]
Products
Total CPU difference: 10489.11000000006 / 10515.620000000044 [-0.25%]
Windows-64-VC14:
OCCT
Total CPU difference: 17802.03125 / 17822.375 [-0.11%]
Products
Total CPU difference: 12072.71875 / 12126.671875 [-0.44%]

Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
12Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]