DiscussionsIssue archiveOCCT:Visualization

Archived issue #0030901

Visualization - OSD_MemInfo moving memory computation out of the constructor

Open CASCADEOCCT:Visualizationclosed11 public notes

Search issues

Description

It's proposed to compute memory values by additional call after the instance of memory info has created.
The case is to avoid additional computation if the variable is only declared in the code and is planned to be used later.

Also, it's proposed to return Standard_Real value in ValueMiB() instead of Standard_Size. It might be useful for cases then result is less than 1Mb.

Public activity

11 archived notes

Participants are labeled by their role within this record.

01Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Aug 15 08:40:14 2019 +0300

    0030901: Visualization - OSD_MemInfo moving memory computation out of the constructor
02Commenter 3
Please don't change existing API.
In case if in application you would like to avoid Update() in constructor - add/extend constructor with bool flag.
In case if you want take MiB in floating point number - add new method.
03Commenter 2
Branch [archived branch] has been created by Author.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Aug 15 13:17:18 2019 +0300

    0030901: Visualization - OSD_MemInfo moving memory computation out of the constructor
04Author
05Commenter 2
Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Author
Date: Thu Aug 15 13:17:18 2019 +0300

    0030901: Visualization - OSD_MemInfo moving memory computation out of the constructor
06Commenter 2
Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]
07Commenter 3
Please take the patch CR30901_2.
08Commenter 1
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16096.510000000038 / 16116.33000000002 [-0.12%]
Products
Total CPU difference: 10480.480000000054 / 10475.390000000047 [+0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 17527.25 / 17461.53125 [+0.38%]
Products
Total CPU difference: 12170.8125 / 11990.921875 [+1.50%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
09Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
10Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]
11Commenter 2
Branch [archived branch] has been deleted by Participant.

[revision removed]