Archived issue #0031220
Visualization - remove internal field of viewer selector in context
Description
AIS_InteractiveContext contains field:
Also, this instance exists in
It's proposed to remove myMainSel from context and obtain this value from the selection manager.
Handle(StdSelect_ViewerSelector3d) myMainSel;
Also, this instance exists in
Handle(SelectMgr_SelectionManager) mgrSelector;
It's proposed to remove myMainSel from context and obtain this value from the selection manager.
Steps to reproduce
Not required
Public activity
12 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Participant.
[revision removed]
Detailed log of new commits:
Author: CheskoArt
Date: Thu Jul 29 13:28:19 2021 +0300
0031220: Visualization - remove internal field of viewer selector in context
Removed myMainSel field from AIS_InteractiveContext and obtained this value from mgrSelector.
[revision removed]
Detailed log of new commits:
Author: CheskoArt
Date: Thu Jul 29 13:28:19 2021 +0300
0031220: Visualization - remove internal field of viewer selector in context
Removed myMainSel field from AIS_InteractiveContext and obtained this value from mgrSelector.
I propose merging SelectMgr_ViewerSelector3d into SelectMgr_ViewerSelector in scope of this patch to get rid of redundant separation and extra DownCast's.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Ready for review
+ public: + + //! Displays sensitives in view <theView>.
Please correct indentation of 'public:'.
--- a/src/SelectMgr/SelectMgr_ViewerSelector3d.hxx +++ /dev/null
Please restore this file and put typedef alias to old class name with deprecated notice.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Ready for review
When you delete/add the file, `FILES` should be updated as well.
And please rebase the patch against the actual master before sending it for testing/review - there are merge conflicts.
And please rebase the patch against the actual master before sending it for testing/review - there are merge conflicts.
Branch [archived branch] has been updated forcibly by Participant.
[revision removed]
[revision removed]
Updated 'FILES', and synchronized with master. Ready for review.
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17368.20000000041 / 17370.70000000038 [-0.01%]
Products
Total CPU difference: 11492.330000000085 / 11466.840000000084 [+0.22%]
Windows-64-VC14:
OCCT
Total CPU difference: 19143.8125 / 19180.875 [-0.19%]
Products
Total CPU difference: 12803.65625 / 12837.4375 [-0.26%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17368.20000000041 / 17370.70000000038 [-0.01%]
Products
Total CPU difference: 11492.330000000085 / 11466.840000000084 [+0.22%]
Windows-64-VC14:
OCCT
Total CPU difference: 19143.8125 / 19180.875 [-0.19%]
Products
Total CPU difference: 12803.65625 / 12837.4375 [-0.26%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records