Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value

This is historic implementation of method TCollection_AsciiString::IsRealValue() - it always returned true if the string was started with some characters that can be interpreted as integer or real value. I propose we can document this in the comment to the method, but it is better not to change behavior as it can break some existig code. Perhaps additional Boolean argument can be added indicating the need for a strict check.

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict check

+  //! theToCheckFull - argument indicating the need for a strict check is the AsciiString a real value.

Please use @param syntax for documenting arguments.
> argument indicating the need for a strict check is the AsciiString a real value.
when TRUE, checks if entire string defines a real value;
otherwise checks if string starts with a real value

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Thu Dec 17 13:21:18 2020 +0300

    kgv remarks:
    - changed description of TCollection_AsciiString::IsRealValue

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict check

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Thu Dec 17 14:14:18 2020 +0300

    # fixed code style

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict check

Please update existing places of IsRealValue() usage in ViewerTest to use new flag and add a test case.

There is OCC11758 command in QABugs_19.cxx which can be extended to verify IsRealValue() in unit-test alike style.

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Fri Dec 18 14:26:35 2020 +0300

    # kgv remarks
     - Extended OCC11758 command in QABugs_19.cxx to verify IsRealValue()
     - Updated existing places of IsRealValue() usage in ViewerTest to use new flag

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict
    - Extended OCC11758 command in QABugs_19.cxx to verify IsRealValue()
    - Updated existing places of IsRealValue() usage in ViewerTest to use new flag

Please fix compiler warnings:

/dn62/builds/CR31226_3-master-KGV/OCCT_SRC/src/TCollection/TCollection_AsciiString.cxx: In member function 'Standard_Boolean TCollection_AsciiString::IsRealValue(Standard_Boolean) const':
/dn62/builds/CR31226_3-master-KGV/OCCT_SRC/src/TCollection/TCollection_AsciiString.cxx:772:23: warning: NULL used in arithmetic [-Wpointer-arith]
[  2%] Building CXX object src/TKernel/CMakeFiles/TKernel.dir/__/Message/Message_Messenger.cxx.o

Branch [archived branch] has been updated by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Fri Dec 18 16:53:58 2020 +0300

    # replaced NULL by '\0'

Branch [archived branch] has been created by Participant.

[revision removed]


Detailed log of new commits:

Author: mkrylova
Date: Mon Dec 14 15:18:43 2020 +0300

    0031226: Foundation Classes - TCollection_AsciiString::IsRealValue() returns true if a string contains a non-real value
    
    - Added comment to the method
    - Added Boolean argument indicating the need for a strict
    - Extended OCC11758 command in QABugs_19.cxx to verify IsRealValue()
    - Updated existing places of IsRealValue() usage in ViewerTest to use new flag

Branch [archived branch] has been updated by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Fri Dec 18 22:14:28 2020 +0300

    # fix misprint in test case

Please raise the patch
- OCCT branch: [archived branch]

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31226_4-master-KGV/

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17722.770000000193 / 17710.950000000055 [+0.07%]
Products
Total CPU difference: 12416.490000000109 / 12412.520000000126 [+0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19321.5625 / 19274.6875 [+0.24%]
Products
Total CPU difference: 13844.421875 / 13853.046875 [-0.06%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]