Archived issue #0031333
Data Exchange - RWGltf_TriangulationReader::readBuffer() fails to read interleaved buffer at the end of file
Description
Reading interleaved buffer at the end of file leads to error due to no padding bytes. This is because Standard_ReadBuffer defines end of stream as Stride*Count, while tail might be cut to element size for the last element.
Public activity
5 archived notes
Participants are labeled by their role within this record.
Branch [archived branch] has been created by Author.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Jan 30 17:10:29 2020 +0300
0031333: Data Exchange - RWGltf_TriangulationReader::readBuffer() fails to read interleaved buffer at the end of file
Standard_ReadBuffer has been extended with a flag for reading an interleaved data.
RWGltf_TriangulationReader::readBuffer() uses new flag for reading vertex attributes.
[revision removed]
Detailed log of new commits:
Author: Author
Date: Thu Jan 30 17:10:29 2020 +0300
0031333: Data Exchange - RWGltf_TriangulationReader::readBuffer() fails to read interleaved buffer at the end of file
Standard_ReadBuffer has been extended with a flag for reading an interleaved data.
RWGltf_TriangulationReader::readBuffer() uses new flag for reading vertex attributes.
Patch is ready for review.
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31333-master-KGV/view/COMPARE/
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31333-master-KGV/view/COMPARE/
Branch [archived branch] has been updated forcibly by Author.
[revision removed]
[revision removed]
Tested in framework of WEEK-6:
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17009.640000000178 / 16997.920000000046 [+0.07%]
Products
Total CPU difference: 12143.5600000001 / 12129.400000000101 [+0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 18438.515625 / 18439.75 [-0.01%]
Products
Products
Total CPU difference: 12143.5600000001 / 12129.400000000101 [+0.11%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.
Number of compiler warnings:
No new/fixed warnings
Regressions/Differences/Improvements:
No regressions/differences
CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17009.640000000178 / 16997.920000000046 [+0.07%]
Products
Total CPU difference: 12143.5600000001 / 12129.400000000101 [+0.12%]
Windows-64-VC14:
OCCT
Total CPU difference: 18438.515625 / 18439.75 [-0.01%]
Products
Products
Total CPU difference: 12143.5600000001 / 12129.400000000101 [+0.11%]
Image differences :
No differences that require special attention
Memory differences :
No differences that require special attention
Branch [archived branch] has been deleted by Participant.
[revision removed]
[revision removed]
Related records