Visualization, AIS_TextLabel - add missing getters

Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Mar 26 10:03:48 2020 +0300

    0031459: Visualization, AIS_TextLabel - add missing getters
    
    Add getters for Text, Fond and FontAspect properties

The patch CR31459 is ready to review

+  Standard_EXPORT const TCollection_ExtendedString& Text() const { return myText; }
+  Standard_EXPORT const TCollection_AsciiString& GetFontName() const { return myFont; }
+  Standard_EXPORT const Font_FontAspect& GetFontAspect() const { return myFontAspect; }

Unexpected EXPORT of inline methods.

 158   myFont = theFont;
...
+  myFontAspect = theFontAspect;

It would be better removing duplicated properties and rely on myDrawer->TextAspect().

GetFontName(), GetFontAspect()

Better FontName()/FontAspect() for consistency with other getters in the class.

Branch [archived branch] has been updated by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Mar 26 16:59:32 2020 +0300

    remarks from kgv

Branch [archived branch] has been created by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Mar 26 10:03:48 2020 +0300

    0031459: Visualization, AIS_TextLabel - add missing getters
    
    Add getters for Text, Fond and FontAspect properties

The patch CR31459 is ready to review

+const Font_FontAspect AIS_TextLabel::FontAspect() const

Redundant const for non-reference return.

+  myDrawer->TextAspect()->SetFont ("Courier");

As previously "Courier" was ignored, it is better removing this line to preserve previous result.

Branch [archived branch] has been updated by Commenter 3.

[revision removed]


Detailed log of new commits:

Author: Commenter 3
Date: Thu Mar 26 17:31:21 2020 +0300

    remarks from kgv

Branch [archived branch] has been updated forcibly by Commenter 3.

[revision removed]

The patch CR31459 is ready to review

Please raise the patch in OCCT branch CR31459_1.

Combination -
OCCT branch : [archived branch]
master SHA - [revision removed]
[revision removed]
Products branch : [archived branch] SHA - [revision removed]
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16868.620000000134 / 16846.320000000138 [+0.13%]
Products
Total CPU difference: 11317.180000000084 / 11306.210000000074 [+0.10%]
Windows-64-VC14:
OCCT
Total CPU difference: 18288.046875 / 18268.796875 [+0.11%]
Products
Total CPU difference: 13120.859375 / 13110.609375 [+0.08%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

Branch [archived branch] has been deleted by Participant.

[revision removed]

Branch [archived branch] has been deleted by Participant.

[revision removed]